Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Search Book Functionality #106

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

rishabhrawat05
Copy link
Contributor

Hey! @Guhapriya01
The Search Functionality has been implemented. Please review the code for further improvement and correctness
Here are some screenshots
{FCB6E6CD-66D1-4617-A0BD-A888176980E0}
{65E283C5-B4AA-4402-A303-909B59B685F7}
{A5241838-36B7-4658-855B-61DC400D2FF4}

@Guhapriya01
Copy link
Collaborator

@rishabhrawat05, Great job on the search functionality! Could you add a null or empty check for the keyword parameter in the searchBook method within the BookService class? This will help prevent unnecessary db queries when keyword is missing. Other than this, everything looks good.

Thanks for your effort on this!

@rishabhrawat05
Copy link
Contributor Author

Hey! @Guhapriya01
I have updated the search function to handle null checks for keyword. Please kindly review the changes
Here are some screenshots of updated improvements
image
image
image

@Guhapriya01 Guhapriya01 merged commit fa6ce6c into ajaynegi45:main Nov 9, 2024
1 of 2 checks passed
@Guhapriya01 Guhapriya01 added enhancement New feature or request hacktoberfest-accepted hacktoberfest gssoc GirlScript Summer Of Code gssoc-ext level3 GirlScript Summer Of Code - 35 points labels Nov 9, 2024
@Guhapriya01
Copy link
Collaborator

Hey @rishabhrawat05,

Thank you for updating the search function with null checks for the keyword! I reviewed the code, and everything looks perfect, so I’ve gone ahead and merged it.

Thanks again for your contribution! 😊

@rishabhrawat05
Copy link
Contributor Author

Hey @rishabhrawat05,

Thank you for updating the search function with null checks for the keyword! I reviewed the code, and everything looks perfect, so I’ve gone ahead and merged it.

Thanks again for your contribution! 😊

😊 Thank you @Guhapriya01. And just one suggestion as this search API is authenticated for users If you want users to search without login, you can go to the security config file and add this API and mark it permit for all.

@Guhapriya01
Copy link
Collaborator

😊 Thank you @Guhapriya01. And just one suggestion as this search API is authenticated for users If you want users to search without login, you can go to the security config file and add this API and mark it permit for all.

Thanks for the suggestion, @rishabhrawat05! 😊 That’s a great point. I’ll make the necessary changes in the security config to allow unauthenticated users to access the search API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc GirlScript Summer Of Code gssoc-ext hacktoberfest hacktoberfest-accepted level3 GirlScript Summer Of Code - 35 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants