-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@23 Changed version to java 17 to pass build checks. #43
Conversation
@@ -57,7 +57,10 @@ | |||
<artifactId>mysql-connector-j</artifactId> | |||
<scope>runtime</scope> | |||
</dependency> | |||
|
|||
<dependency> | |||
<groupId>org.apache.tomcat.embed</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add this dependency?
org.apache.tomcat.embed
|
||
# Change this connection string to this format: jdbc:mysql://{ip_address}:{port}/{database_name} | ||
spring.datasource.url=jdbc:mysql://localhost:3306/Add_Your_Database_Name | ||
# MySQL Database Connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this file as it was earlier before commiting code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your prompt work on the issue. I appreciate your dedication to the project.
I have reviewed your work, and I need some changes.
- Mentioned in code Comment.
Once again, thank you for your contribution! ❤️
Sure I'll correct it. |
Hello PA,
changed version back to java 17 for passing build checks.
Kindly Review .