Update MemberService.java #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented logic to check if the member has any outstanding fines or borrowed books and further deleted all related notifications, borrowings and fines.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎉 Thank you @Divyansh123bn for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
ajaynegi45
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Hi @Divyansh123bn,
Thank you for your prompt work on this issue. I appreciate your dedication to the project.
I have reviewed your work, and I need some changes.
- Mention all proper Imports
- Read all code comments
Once again, thank you for your contribution! ❤️
ajaynegi45
reviewed
Oct 3, 2024
ajaynegi45
reviewed
Oct 3, 2024
| // TODO: Implement logic to check if the member has any outstanding fines or borrowed books. | ||
| // If there are no pending obligations, delete all related notifications, borrowings, and fines. | ||
| // Check for outstanding fines | ||
| List<Fine> outstandingFines = fineRepository.findByMemberIdAndIsPaidFalse(memberId); |
ajaynegi45
reviewed
Oct 3, 2024
|
|
||
| // Check for borrowed books | ||
| List<Borrowings> borrowedBooks = borrowingRepository.getAllBorrowingsOfAMember(memberId); |
ajaynegi45
reviewed
Oct 3, 2024
| } | ||
|
|
||
| // Delete related notifications | ||
| notificationRepository.deleteByMemberId(memberId); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented logic to check if the member has any outstanding fines or borrowed books and further deleted all related notifications, borrowings and fines.