Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Exception Handling for Invalid Sort Fields #56

Merged

Conversation

Guhapriya01
Copy link
Collaborator

Changes Made:

  • Refactored PropertyReferenceException to throw a meaningful error response across all the service methods that deals with pagination and sorting.

Error Response Example:

{
    "timestamp": "2024-10-03T07:37:08.364+00:00",
    "message": "The specified 'sortBy' value is invalid.",
    "details": "/api/books"
}

Copy link
Owner

@ajaynegi45 ajaynegi45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Guhapriya01,

Thank you for your prompt work on this issue. I appreciate your dedication to the project.

I have reviewed your work, and I'm pleased to inform you that I have merged your pull request. Your changes looks fantastic, and it aligns perfectly with the project's design and usability goals. Great job!

I have mention some comment reply them.

If you have any more contributions or if there's anything else you'd like to work on in the future, please don't hesitate to let us know. Your efforts are valuable to the project's success.

Once again, thank you for your contribution! ❤️

@ajaynegi45 ajaynegi45 merged commit ba96678 into ajaynegi45:main Oct 3, 2024
1 of 2 checks passed
@Guhapriya01
Copy link
Collaborator Author

Hi Ajay!

Thank you for the kind words! I’m glad to hear that my changes were well-received and aligned with the project goals. I have replied to the comments you mentioned and am eager to keep contributing to the project!

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants