#4 UX/UI of hero section improved align with design best practices #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaynegi45
reviewed
Oct 7, 2023
There was a problem hiding this comment.
On Changes
Hi @Sky-De,
Thank you for your prompt work on the "UX/UI of hero section improved align with design best practices" issue. I appreciate your dedication to the project.
I have reviewed your work, and the problem you have shown in #4 (comment), I think these problem are already resolve.
Once again, thank you for your contribution! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for issue #4
I have made two changes to the code: I commented out the Hero component and redesigned the search-book component. Please refer to the attached gifs and complete explanation on issue #4 page for more details. Most of the changes are related to prettier extensions, and the main code change is just about some CSS code. Merge it and review it online. If you are unsatisfied with the changes, please provide your desired design, and I will fix it. Thank you.