Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#90 : ENHANCEMENT: Show Newsletter Subscription Confirmation message solved #95

Closed
wants to merge 1 commit into from

Conversation

Anwishta
Copy link

@Anwishta Anwishta commented Oct 5, 2024

Description:

This pull request solves issue #90. It adds email validation to the newsletter subscription form, ensuring that the user enters a valid email address before showing the subscription confirmation modal. If the email address is invalid, an error message is displayed, and the subscription modal does not appear.

Changes Included:

Email Validation Logic:

A regular expression is used to validate the email format before submission.
If the email is invalid, the user is prompted with a clear error message asking them to input a valid email address.

Modal Visibility Control:

The subscription modal will only be shown if the user inputs a valid email.
This enhances the user experience by preventing invalid form submissions and unnecessary modal popups.

Form Handling:

Added onSubmit to the form to handle the submission properly, preventing default behavior until email validation is successful.

Error Message Display:

If the email is not valid, an error message is dynamically displayed under the input field.
Error message disappears once a new valid email is entered.

Screen Record :

Screen.Recording.2024-10-05.182333.mp4

Testing:

Tested the form with both valid and invalid email formats.
Ensured that the modal appears only when the email is valid.
Verified that error messages are displayed correctly for invalid input.

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for library-man ready!

Name Link
🔨 Latest commit 6c51650
🔍 Latest deploy log https://app.netlify.com/sites/library-man/deploys/67013839391e1900087752c7
😎 Deploy Preview https://deploy-preview-95--library-man.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Devamani11D Devamani11D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anwishta
This looks really cool!!
The modal looks good and it's integration and email verification is perfect. Thank you for your contribution to the project and keep up the good work and expecting more contributions from you 🚀 😄

@ajaynegi45
Copy link
Owner

ajaynegi45 commented Oct 10, 2024

Description:

This pull request solves issue #90. It adds email validation to the newsletter subscription form, ensuring that the user enters a valid email address before showing the subscription confirmation modal. If the email address is invalid, an error message is displayed, and the subscription modal does not appear.

Changes Included:

Email Validation Logic:

A regular expression is used to validate the email format before submission. If the email is invalid, the user is prompted with a clear error message asking them to input a valid email address.

Modal Visibility Control:

The subscription modal will only be shown if the user inputs a valid email. This enhances the user experience by preventing invalid form submissions and unnecessary modal popups.

Form Handling:

Added onSubmit to the form to handle the submission properly, preventing default behavior until email validation is successful.

Error Message Display:

If the email is not valid, an error message is dynamically displayed under the input field. Error message disappears once a new valid email is entered.

Screen Record :

Screen.Recording.2024-10-05.182333.mp4

Testing:

Tested the form with both valid and invalid email formats. Ensured that the modal appears only when the email is valid. Verified that error messages are displayed correctly for invalid input.

I think the error message you shown is default html validation message not your. Make the required changes and make new pr

@ajaynegi45 ajaynegi45 closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants