-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made Newsletter Functional #66
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RiteshS1,
Thank you for your prompt work on this issue. I appreciate your dedication to the project.
I have reviewed your work, and I need some changes.
-
Replace the text 'Submitting' with a circular loading icon.
Screen.Recording.2024-10-04.at.6.40.16.PM.mov
-
Remove the highlighted text and use Sonner library for message.
-
How can I retrieve those submitted emails?
Once again, thank you for your contribution! ❤️
Hei @ajaynegi45 ; I would have worked upon those suggestions but why did u close this pr w/o assigning any labels? |
Also regarding your query to retrieve mails; well there are more than one ways to do so like using MongoDB or GoogleSheets or even a JSON to store the entered mails; depends on the need. |
Hi @RiteshS1, Thanks for your understanding! |
Which one is better according to you. |
Fixed #49
The Newsletter now sends a welcome mail to the subscribed users!
I have deployed my improved version for testing check it out at https://uttarakhand-culture-new-ui-ritesh.vercel.app/
You'll just have to add environment variables at the time of your deployment as ;
SMTP_USER=[email protected]
SMTP_PASSWORD=your-password
To test it locally just create a .env.local file and add the passwords there.
The mail can be further customized as per your requirements!
Let me know if there's something to improve on...