Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Newsletter Functional #66

Closed
wants to merge 5 commits into from
Closed

Conversation

RiteshS1
Copy link

@RiteshS1 RiteshS1 commented Oct 4, 2024

Fixed #49

The Newsletter now sends a welcome mail to the subscribed users!

I have deployed my improved version for testing check it out at https://uttarakhand-culture-new-ui-ritesh.vercel.app/

You'll just have to add environment variables at the time of your deployment as ;

SMTP_USER=[email protected]
SMTP_PASSWORD=your-password

To test it locally just create a .env.local file and add the passwords there.

The mail can be further customized as per your requirements!

Let me know if there's something to improve on...

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uttarakhand-culture ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 0:33am

Copy link
Owner

@ajaynegi45 ajaynegi45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RiteshS1,

Thank you for your prompt work on this issue. I appreciate your dedication to the project.

I have reviewed your work, and I need some changes.

  • Replace the text 'Submitting' with a circular loading icon.

    Screenshot 2024-10-04 at 6 10 04 PM
    Screen.Recording.2024-10-04.at.6.40.16.PM.mov
  • Remove the highlighted text and use Sonner library for message.
    Screenshot 2024-10-04 at 6 09 38 PM

  • How can I retrieve those submitted emails?

Once again, thank you for your contribution! ❤️

@ajaynegi45 ajaynegi45 closed this Oct 4, 2024
@RiteshS1
Copy link
Author

RiteshS1 commented Oct 4, 2024

Hei @ajaynegi45 ; I would have worked upon those suggestions but why did u close this pr w/o assigning any labels?

@RiteshS1
Copy link
Author

RiteshS1 commented Oct 4, 2024

Also regarding your query to retrieve mails; well there are more than one ways to do so like using MongoDB or GoogleSheets or even a JSON to store the entered mails; depends on the need.

@ajaynegi45
Copy link
Owner

Hei @ajaynegi45 ; I would have worked upon those suggestions but why did u close this pr w/o assigning any labels?

Hi @RiteshS1,
I'm currently managing several projects that are participating in Hacktoberfest and GSSoC, which means I'm receiving multiple pull requests daily. This has made it a bit challenging to track which ones I've reviewed. I usually close PRs that I have checked, and it seems yours was also closed. Please don't worry about it—just make the necessary changes and submit a new PR. If everything looks good, I'll make sure to merge it.

Thanks for your understanding!

@ajaynegi45
Copy link
Owner

Also regarding your query to retrieve mails; well there are more than one ways to do so like using MongoDB or GoogleSheets or even a JSON to store the entered mails; depends on the need.

Which one is better according to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correcting the Join the Newsletter option
3 participants