refactor: ♻️ refactor Events to use enum and better type checking #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem with the onHover event that led me down a rabbit hole. With multiple developers it seems almost a necessity to use an enum for events to make sure we aren't doing the same thing with different string names. I also added better typing for the fireEvent method to make sure you are passing the correct data. Sorry this is a large change.
Missed these when trying to commit changes only related to the events
ajmas
reviewed
Jan 8, 2024
|
Just need to deal with a merge conflict here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with the onHover event that led me down a rabbit hole. With multiple developers it seems almost a necessity to use an enum for events to make sure we aren't doing the same thing with different string names. I also added better typing for the fireEvent method to make sure you are passing the correct data. Sorry this is a large change.