Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #70

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Refactoring #70

merged 7 commits into from
Sep 19, 2023

Conversation

MikeHathaway
Copy link
Contributor

@MikeHathaway MikeHathaway commented Sep 18, 2023 •
edited
Loading

  • Add additional sections and reorder methods in erc20-pools.ts to match erc721-pools.ts
  • Add _handleBondWithdrawn base handler

@MikeHathaway MikeHathaway marked this pull request as ready for review September 18, 2023 15:10
EdNoepel
EdNoepel approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Methods used to be in alphabetical order, which I found somewhat annoying, but maintained nonetheless. This seems better.

@MikeHathaway MikeHathaway merged commit c9da759 into develop Sep 19, 2023
1 check passed
@MikeHathaway MikeHathaway deleted the refactoring branch September 19, 2023 13:39
@MikeHathaway MikeHathaway restored the refactoring branch September 19, 2023 14:57
@MikeHathaway MikeHathaway deleted the refactoring branch September 19, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdNoepel EdNoepel EdNoepel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeHathaway @EdNoepel