Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and Update Allowances and Transferors #71

Merged
merged 14 commits into from
Sep 20, 2023
Merged

Test and Update Allowances and Transferors #71

merged 14 commits into from
Sep 20, 2023

Conversation

MikeHathaway
Copy link
Contributor

@MikeHathaway MikeHathaway commented Sep 18, 2023 •
edited
Loading

@MikeHathaway MikeHathaway changed the base branch from develop to refactoring September 18, 2023 17:53
@MikeHathaway MikeHathaway marked this pull request as ready for review September 18, 2023 18:14
EdNoepel
EdNoepel reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. One comment inline.

src/mappings/base/base-pool.ts Show resolved Hide resolved
@MikeHathaway MikeHathaway deleted the branch develop September 19, 2023 13:39
@MikeHathaway MikeHathaway reopened this Sep 19, 2023
@MikeHathaway MikeHathaway changed the base branch from refactoring to develop September 19, 2023 14:59
EdNoepel
EdNoepel approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeHathaway MikeHathaway merged commit f0727d8 into develop Sep 20, 2023
1 check passed
@MikeHathaway MikeHathaway deleted the test-allowance branch September 20, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdNoepel EdNoepel EdNoepel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeHathaway @EdNoepel