Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merge collateral #73

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Fix merge collateral #73

merged 2 commits into from
Oct 5, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Oct 5, 2023 •
edited
Loading

Assigned the pool member of the event entity, and recorded some calldata for use in unit test.
Tested by deploying directly to aditi, which was down anyway.

@EdNoepel EdNoepel requested a review from MikeHathaway October 5, 2023 17:27
MikeHathaway
MikeHathaway approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel merged commit 5a5c222 into develop Oct 5, 2023
1 check passed
@EdNoepel EdNoepel deleted the fix-merge-collateral branch October 5, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdNoepel @MikeHathaway