RC9 Updates #81
RC9 Updates #81
Conversation
schema.graphql
Outdated
| @@ -713,7 +716,7 @@ type Position @entity { | |||
| tokenId: BigInt # tokenId | |||
| indexes: [PositionLend!]! # list of PositionLends which constitute a position | |||
| owner: Bytes! # address of the position owner | |||
| pool: Bytes! # address of the pool that the position is associated with | |||
There was a problem hiding this comment.
Should also add a poolAddress Bytes here, so consumers can filter positions by pool.
There was a problem hiding this comment.
This change was already made to Develop by Tim and was accidentally pulled in again here. Can add the additional param as part of the RC9 updates.
| @@ -193,6 +193,8 @@ type Loan @entity { | |||
| liquidationAuction: LiquidationAuction | |||
| # collateral tokens deposited in a pool by the borrower | |||
| collateralPledged: BigDecimal! | |||
| # borrower's threshold price in t0 terms | |||
| thresholdPrice: BigDecimal! | |||
There was a problem hiding this comment.
Should probably name this t0thresholdPrice, consistent with t0debt.
There was a problem hiding this comment.
Updated accordingly
schema.graphql
Outdated
| @@ -194,7 +194,7 @@ type Loan @entity { | |||
| # collateral tokens deposited in a pool by the borrower | |||
| collateralPledged: BigDecimal! | |||
| # borrower's threshold price in t0 terms | |||
| thresholdPrice: BigDecimal! | |||
| t0ThresholdPrice: BigDecimal! | |||
There was a problem hiding this comment.
nit: We kept a lowercase d in t0debt. Should t be lowercase here? Or should we rename t0Debt?
There was a problem hiding this comment.
We're returning a t0Np in the contracts and had the mismatch there previously. Updating to t0Debt feels more correct but fine lowercasing
There was a problem hiding this comment.
Either way is fine with me, and happy to leave it for a future PR if desired.
|
Need ajna-finance/ajna-core#1017 to be merged first in order to update the ABI |
copy-abis.shand ran it. Forge compiler output seems to have changed slightly, but tests run fine.ThresholdPricetoLoanandLiquidationAuctionentitiest0NptoLoanentities.auctionInfocalls and tests to account for the interface changeborrowerInfocalls and tests