Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import to docker form board, Docker button on boards #1714

Merged
merged 7 commits into from
Dec 30, 2023
Merged

Import to docker form board, Docker button on boards #1714

merged 7 commits into from
Dec 30, 2023

Conversation

ajnart
Copy link
Owner

@ajnart ajnart commented Nov 26, 2023 •
edited
Loading

What's done

  • Allow adding multiple Docker apps at once
  • Docker button on all boards for admins (to manage/add containers)
  • Prefetching of Docker containers on page load

Issues

  • Config doesn't get reloaded when adding apps, idk how to make it reload without reloading the page (or I don't know how to get the current config from the memory anymore to add the newly added items to it via setConfig())
  • The modal opening another modal is quite ugly, I wish the "add to board" button would have the context and add to the current board instead.

Solutions

  • Leave it as is
  • Find a way to set the current config (in the memory, the backend one is properly mutated) like we could before with useConfigContext
  • Change the way we load the config to a trpc procedure so that it can be easily reloaded (refetched)

Screenshots

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 16.5% 4604 / 27888
🔵 Statements 16.5% 4604 / 27888
🔵 Functions 6.62% 29 / 438
🔵 Branches 38.08% 123 / 323
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/Dashboard/Modals/SelectElement/SelectElementModal.tsx 0% 0% 0% 0% 1-25
src/components/Dashboard/Modals/SelectElement/Components/Overview/AvailableElementsOverview.tsx 0% 0% 0% 0% 1-142
src/components/Dashboard/Modals/SelectElement/Components/WidgetsTab/AvailableWidgetsTab.tsx 0% 0% 0% 0% 1-31
src/components/Manage/Tools/Docker/ContainerActionBar.tsx 17% 100% 0% 17% 24-104, 107-147
src/components/Manage/Tools/Docker/ContainerTable.tsx 18.53% 100% 0% 18.53% 22-27, 30-111, 121-171, 173-178
src/components/Manage/Tools/Docker/docker-select-board.modal.tsx 18.18% 100% 0% 18.18% 25-130, 133-143
src/components/layout/Templates/BoardLayout.tsx 19.77% 100% 0% 19.77% 37-48, 51-62, 65-105, 108-119, 125-216, 219-237, 240-260, 263-268
src/pages/board/index.tsx 0% 0% 0% 0% 1-83
src/server/api/routers/app.ts 0% 0% 0% 0% 1-75
src/server/api/routers/board.ts 0% 0% 0% 0% 1-89
src/server/api/routers/icon.ts 0% 0% 0% 0% 1-38
src/server/api/routers/overseerr.ts 0% 0% 0% 0% 1-217
src/server/api/routers/docker/router.ts 0% 0% 0% 0% 1-94
src/tools/server/translation-namespaces.ts 100% 100% 100% 100%
Generated in workflow #6003

@ajnart ajnart changed the title Draft: Import to docker form board, Docker button on boards Import to docker form board, Docker button on boards Dec 7, 2023
@ajnart
Copy link
Owner Author

ajnart commented Dec 7, 2023

@manuel-rw this is ready for review

@manuel-rw manuel-rw added the ✨ Feature A feature you'd like to be added label Dec 7, 2023
manuel-rw
manuel-rw reviewed Dec 17, 2023
View reviewed changes
src/pages/onboard.tsx Outdated Show resolved Hide resolved
manuel-rw
manuel-rw requested changes Dec 17, 2023
View reviewed changes
src/server/api/routers/app.ts Outdated Show resolved Hide resolved
src/server/api/routers/overseerr.ts Show resolved Hide resolved
src/server/api/routers/overseerr.ts Show resolved Hide resolved
@manuel-rw manuel-rw merged commit 082077e into dev Dec 30, 2023
3 checks passed
@manuel-rw manuel-rw deleted the docker-onboarding branch December 30, 2023 19:11
truecharts-admin referenced this pull request in truecharts/public Dec 31, 2023
@truecharts-admin
chore(deps): update container image ghcr.io/ajnart/homarr to v0.14.3@…
0a61f70 
…45f163b by renovate (#16654)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/ajnart/homarr](https://togithub.com/ajnart/homarr) | patch |
`0.14.2` -> `0.14.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ajnart/homarr (ghcr.io/ajnart/homarr)</summary>

### [`v0.14.3`](https://togithub.com/ajnart/homarr/releases/tag/v0.14.3)

[Compare
Source](https://togithub.com/ajnart/homarr/compare/v0.14.2...v0.14.3)

### 🎆🎆 Happy new Year!

Thank you for all your support in 2023 - we really appreciate it.
Homarr has been downloaded almost 4 million times with over 400'000
instances running the latest versions.
Due to the increase in traffic, we have upgraded our website at
https://homarr.dev/ significantly and moved our infrastructure to a
hosting provider.
We are looking forward to see you in 2024!

#### Better user management


![image](https://togithub.com/ajnart/homarr/assets/30572287/5bf6221b-0803-46df-8ae7-9666e6662fe6)

#### Redesigned torrent table

Thanks to [@&#8203;InterN0te](https://togithub.com/InterN0te) , our
torrent widget has received a great upgrade:

![image](https://togithub.com/ajnart/homarr/assets/30572287/1f16c5d9-448f-48f7-948e-9b9f8d75ecb4)

#### Gravatar support

Homarr now integrates seamlessly with Gravatar. Simply upload a profile
picture to Gravatar and you're good to go!


![image](https://togithub.com/ajnart/homarr/assets/30572287/f5cbd6eb-26dd-41e6-8423-39bf4d411873)

#### Updated docker integration

We've added back the Docker integration to your boards.
It's now easier to use than ever.


![image](https://togithub.com/ajnart/homarr/assets/30572287/2308915a-04ac-4504-ad10-24f70eaf9c90)

![image](https://togithub.com/ajnart/homarr/assets/30572287/401db133-2dc5-42af-aef5-cd86ed1ebd33)

#### CLI tool

Did you get locked out? Using our CLI tool, you can reset your password
to recover your Homarr instance:

![image](https://togithub.com/ajnart/homarr/assets/30572287/b8fb30cd-c7e7-4bd3-ab43-d0b5f955197f)

#### What's Changed

- Update acceptableStatusCodes.ts by
[@&#8203;jeffersonraimon](https://togithub.com/jeffersonraimon) in
[https://github.com/ajnart/homarr/pull/1709](https://togithub.com/ajnart/homarr/pull/1709)
- ✨ [#&#8203;1616](https://togithub.com/ajnart/homarr/issues/1616)
Recovery script in Docker container by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[https://github.com/ajnart/homarr/pull/1726](https://togithub.com/ajnart/homarr/pull/1726)
- 🐛 About page and manage user pages not translated by
[@&#8203;ajnart](https://togithub.com/ajnart) in
[https://github.com/ajnart/homarr/pull/1724](https://togithub.com/ajnart/homarr/pull/1724)
- ✨ Use gravatar with user email by
[@&#8203;Tagaishi](https://togithub.com/Tagaishi) in
[https://github.com/ajnart/homarr/pull/1688](https://togithub.com/ajnart/homarr/pull/1688)
- Switch torrents Table to MantineReactTable with filter/sort function
by [@&#8203;InterN0te](https://togithub.com/InterN0te) in
[https://github.com/ajnart/homarr/pull/1557](https://togithub.com/ajnart/homarr/pull/1557)
- ⚡️ Improve code in manage layout page by
[@&#8203;Tagaishi](https://togithub.com/Tagaishi) in
[https://github.com/ajnart/homarr/pull/1681](https://togithub.com/ajnart/homarr/pull/1681)
- Updated entityStateSchema to handle nullables by
[@&#8203;gfomichev](https://togithub.com/gfomichev) in
[https://github.com/ajnart/homarr/pull/1744](https://togithub.com/ajnart/homarr/pull/1744)
- feature/[#&#8203;1616](https://togithub.com/ajnart/homarr/issues/1616)
better user management by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[https://github.com/ajnart/homarr/pull/1748](https://togithub.com/ajnart/homarr/pull/1748)
- New Crowdin updates by [@&#8203;ajnart](https://togithub.com/ajnart)
in
[https://github.com/ajnart/homarr/pull/1701](https://togithub.com/ajnart/homarr/pull/1701)
- fix: umlaute in RSS by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[https://github.com/ajnart/homarr/pull/1755](https://togithub.com/ajnart/homarr/pull/1755)
- New Crowdin updates by [@&#8203;ajnart](https://togithub.com/ajnart)
in
[https://github.com/ajnart/homarr/pull/1761](https://togithub.com/ajnart/homarr/pull/1761)
- ⚡️ Remove location based timezone resolving by
[@&#8203;Tagaishi](https://togithub.com/Tagaishi) in
[https://github.com/ajnart/homarr/pull/1680](https://togithub.com/ajnart/homarr/pull/1680)
- Import to docker form board, Docker button on boards by
[@&#8203;ajnart](https://togithub.com/ajnart) in
[https://github.com/ajnart/homarr/pull/1714](https://togithub.com/ajnart/homarr/pull/1714)
- Update FUNDING.yml by [@&#8203;ajnart](https://togithub.com/ajnart) in
[https://github.com/ajnart/homarr/pull/1768](https://togithub.com/ajnart/homarr/pull/1768)
- 🔧 Configure Stale Action by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[https://github.com/ajnart/homarr/pull/1752](https://togithub.com/ajnart/homarr/pull/1752)
- 🔧 Configure greetings by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[https://github.com/ajnart/homarr/pull/1753](https://togithub.com/ajnart/homarr/pull/1753)
- New Crowdin updates by [@&#8203;ajnart](https://togithub.com/ajnart)
in
[https://github.com/ajnart/homarr/pull/1770](https://togithub.com/ajnart/homarr/pull/1770)
- fix: outdated config schema by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[https://github.com/ajnart/homarr/pull/1769](https://togithub.com/ajnart/homarr/pull/1769)
- chore: increase version in package.json by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[https://github.com/ajnart/homarr/pull/1771](https://togithub.com/ajnart/homarr/pull/1771)
- Docker import fix by [@&#8203;ajnart](https://togithub.com/ajnart) in
[https://github.com/ajnart/homarr/pull/1773](https://togithub.com/ajnart/homarr/pull/1773)

#### New Contributors

- [@&#8203;jeffersonraimon](https://togithub.com/jeffersonraimon) made
their first contribution in
[https://github.com/ajnart/homarr/pull/1709](https://togithub.com/ajnart/homarr/pull/1709)
- [@&#8203;gfomichev](https://togithub.com/gfomichev) made their first
contribution in
[https://github.com/ajnart/homarr/pull/1744](https://togithub.com/ajnart/homarr/pull/1744)

**Full Changelog**:
ajnart/homarr@v0.14.2...v0.14.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
manuel-rw added a commit that referenced this pull request Jan 14, 2024
@manuel-rw
revert: #1714 migrate to axios.get
c09b4c5
@manuel-rw manuel-rw mentioned this pull request Jan 14, 2024
Merged
manuel-rw added a commit that referenced this pull request Jan 14, 2024
@manuel-rw
revert: #1714 migrate to axios.get (#1819)
e57af4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-rw manuel-rw manuel-rw approved these changes

@Meierschlumpf Meierschlumpf Awaiting requested review from Meierschlumpf

Assignees

@ajnart ajnart

Labels
✨ Feature A feature you'd like to be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnart @manuel-rw