Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to delete boards with capitalised name 'Default' #2223

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

tancak
Copy link
Contributor

@tancak tancak commented Dec 16, 2024

Thank you for contributing to Homarr! So that your Pull Request can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category

Bugfix

Overview

You can create multiple boards called default as long as the capitalisation is different for each one ('eg 'Default', 'DeFaUlT'), however, when we try to prevent deleting the 'default' board the check is case insensitive and therefore we can't delete these fake default boards. As a side note, I think users should not be allowed to create multiple boards with the same name but different capitalisation in the first place but that seems to be a common theme in other parts of the app.

@manuel-rw manuel-rw added the 🐛 Bug Something isn't working label Dec 17, 2024
@Meierschlumpf Meierschlumpf merged commit 4aa7e76 into ajnart:dev Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants