Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): exports all the generated namespaces (#184) #142

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

ygrishajev
Copy link
Contributor

@ygrishajev ygrishajev commented Apr 4, 2024

PR is aimed to improve usability of originally generated code.

  1. it instructs ts-proto to generate namespaces index files
  2. generated exports dynamically at build time including fallback to ts < 4.5 described in the readme
  3. ignores/cleans generated exports from git

This way the package can already be used which would ease further akashjs refactoring progress.

NOTE: PR contains just a few files changes. src/generated was regenerated and can be skipped while reviewing.

@ygrishajev ygrishajev requested a review from a team as a code owner April 4, 2024 12:23
@ygrishajev ygrishajev requested a review from a team April 4, 2024 12:24
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.51%. Comparing base (14b1f7d) to head (45a9d78).

❗ Current head 45a9d78 differs from pull request most recent head 5ce5676. Consider uploading reports for the commit 5ce5676 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #142   +/-   ##
=====================================
  Coverage   3.51%   3.51%           
=====================================
  Files        296     296           
  Lines      97291   97291           
=====================================
+ Hits        3415    3418    +3     
+ Misses     93697   93694    -3     
  Partials     179     179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

baktun14
baktun14 previously approved these changes Apr 4, 2024
Copy link

@baktun14 baktun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool! Looking forward to having this 100% automated. Good readme 👍

@ygrishajev ygrishajev merged commit d27ac62 into main Apr 9, 2024
6 checks passed
@ygrishajev ygrishajev deleted the feature/ts branch April 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants