Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polkachu and c29r3 #240

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Fix polkachu and c29r3 #240

merged 3 commits into from
Nov 15, 2023

Conversation

88plug
Copy link
Contributor

@88plug 88plug commented Nov 14, 2023

Autostake is down, set default to Polkachu and add support for c29r3 again. (new URL)

Autostake is down, set default to Polkachu and add support for c29r3 again. (new URL)
@andy108369
Copy link
Collaborator

Thank you for PR!
I'll test and merge it if all is good.

Copy link
Collaborator

@andy108369 andy108369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@88plug Only fixed polkachu snapshot provider works.

  • The modified code broke autostake snapshot provider sync. (wrong download link) autostake site is down
  • Added c29r3 snapshot provider doesn't work. (extracts it to a wrong dir)

Please kindly test your code better before submitting PR, it would save us time.

Or, alternatively, if you want the code that you have tested get delivered ASAP => please do split your working & tested code into separate PR, where it would contain the code that you have tested so you know it is working (e.g. the corrected polkachu snapshot provider does work).

See below additional info that will help you to address the issues with this PR.


TEST RESULTS

DEFAULT: polkachu snapshot provider OK 🟢

$ helm upgrade --install akash-node ~/git/akash/helm-charts/charts/akash-node -n akash-services
$ kubectl -n akash-services logs akash-node-1-0 --tail=10000 -f -c init
...
+ cd /root/.akash/data
+ curl -s https://raw.githubusercontent.com/akash-network/net/main/mainnet/genesis.json
+ '[' '' == true ']'
+ '[' akashnet-2 == akashnet-2 ']'
+ apt -y --no-install-recommends install aria2 lz4 liblz4-tool wget
+ case "$SNAPSHOT_PROVIDER" in
+ SNAPSHOTS_DIR_URL=https://snapshots.polkachu.com/snapshots/
+ USER_AGENT='Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36'
++ curl -s -A 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36' https://snapshots.polkachu.com/snapshots/
++ grep -oP 'akash/[^<]+\.tar\.lz4'
++ tail -n1
+ LATEST=akash/akash_13690906.tar.lz4
+ SNAPSHOT_URL=https://snapshots.polkachu.com/snapshots/
+ aria2c --out=snapshot.tar.lz4 --check-certificate=false --max-tries=99 --retry-wait=5 --always-resume=true --max-file-not-found=99 --conditional-get=true -s 8 -x 8 -k 1M -j 1 https://snapshots.polkachu.com/snapshots/akash/akash_13690906.tar.lz4

11/15 11:37:20 [NOTICE] Downloading 1 item(s)
[#b2a909 26MiB/1.5GiB(1%) CN:8 DL:29MiB ETA:53s]
...
11/15 11:38:09 [NOTICE] Download complete: /root/.akash/data/snapshot.tar.lz4
$ kubectl -n akash-services logs akash-node-1-0 --tail=10000 -f  | grep -iv p2p
...
INF committed state app_hash=7BBA18BE0A89A9EE1D53DE7C0CED4A34C66323C4DA73C8BED7EA5BE92B64B2CE height=13691001 module=state num_txs=0
INF indexed block exents height=13691001 module=txindex
INF minted coins from module account amount=3694720uakt from=mint module=x/bank

CUSTOM: autostake snapshot provider FAIL 💥

$ helm upgrade --install akash-node ~/git/akash/helm-charts/charts/akash-node -n akash-services --set akash_node.snapshot_provider=autostake
$ kubectl -n akash-services logs akash-node-1-0 --tail=10000 -f -c init
...
+ cd /root/.akash/data
+ curl -s https://raw.githubusercontent.com/akash-network/net/main/mainnet/genesis.json
+ '[' '' == true ']'
+ '[' akashnet-2 == akashnet-2 ']'
+ apt -y --no-install-recommends install aria2 lz4 liblz4-tool wget
+ case "$SNAPSHOT_PROVIDER" in
+ SNAP_URL=http://snapshots.autostake.com/akashnet-2/
++ egrep -o akashnet-2
++ curl -s http://snapshots.autostake.com/akashnet-2/
++ tail -1
++ tr -d '>'
+ SNAP_NAME=
+ aria2c --out=snapshot.tar.lz4 --check-certificate=false --max-tries=99 --retry-wait=5 --always-resume=true --max-file-not-found=99 --conditional-get=true -s 8 -x 8 -k 1M -j 1 http://snapshots.autostake.com/akashnet-2/

11/15 11:46:56 [NOTICE] Downloading 1 item(s)
[#079be8 0B/0B CN:1 DL:0B]
[#079be8 0B/0B CN:1 DL:0B]
[#079be8 0B/0B CN:1 DL:0B]
[#079be8 0B/0B CN:1 DL:0B]

11/15 11:47:00 [ERROR] CUID#7 - Download aborted. URI=http://snapshots.autostake.com/akashnet-2/
Exception: [AbstractCommand.cc:403] errorCode=4 URI=http://snapshots.autostake.com/akashnet-2/
  -> [RequestGroup.cc:1265] errorCode=4 Reached max-file-not-found count=99

CUSTOM: c29r3 snapshot provider FAIL 💥

$ helm upgrade --install akash-node ~/git/akash/helm-charts/charts/akash-node -n akash-services --set akash_node.snapshot_provider=c29r3
$ kubectl -n akash-services logs akash-node-1-0 --tail=10000 -f -c init
...
+ cd /root/.akash/data
+ curl -s https://raw.githubusercontent.com/akash-network/net/main/mainnet/genesis.json
+ '[' '' == true ']'
+ '[' akashnet-2 == akashnet-2 ']'
+ apt -y --no-install-recommends install aria2 lz4 liblz4-tool wget
+ case "$SNAPSHOT_PROVIDER" in
++ curl -s https://snapshots.c29r3.xyz/akash/
++ tr -d '>'
++ egrep -o '>akashnet-2.*tar'
+ SNAP_NAME=akashnet-2_2023-11-09.tar
+ echo 'Using default c29r3.xyz blockchain snapshot, https://snapshots.c29r3.xyz/akash/akashnet-2_2023-11-09.tar'
+ aria2c --out=snapshot.tar --summary-interval 15 --check-certificate=false --max-tries=99 --retry-wait=5 --always-resume=true --max-file-not-found=99 --conditional-get=true -s 8 -x 8 -k 1M -j 1 https://snapshots.c29r3.xyz/akash/akashnet-2_2023-11-09.tar
Using default c29r3.xyz blockchain snapshot, https://snapshots.c29r3.xyz/akash/akashnet-2_2023-11-09.tar

11/15 11:48:16 [NOTICE] Downloading 1 item(s)
[#fd537b 24MiB/1.7GiB(1%) CN:8 DL:28MiB ETA:1m2s]
...
11/15 11:49:26 [NOTICE] Download complete: /root/.akash/data/snapshot.tar

Download Results:
gid   |stat|avg speed  |path/URI
======+====+===========+=======================================================
fd537b|OK  |    25MiB/s|/root/.akash/data/snapshot.tar

Status Legend:
(OK):download completed.
+ tar -xf snapshot.tar -C /root/.akash
+ rm -rf snapshot.tar
+ [[ false == \t\r\u\e ]]
  • panic fails as it starts with appHeight=0, because c29r3 snapshots gets extracted to a wrong directory /root/.akash/ instead of /root/.akash/data
arno@x1:~$ kubectl -n akash-services logs akash-node-1-0 --tail=10000 -f  | grep -iv p2p
...
INF ABCI Handshake App Info hash= height=0 module=consensus protocol-version=0 software-version=v0.26.2
INF ABCI Replay Blocks appHeight=0 module=consensus stateHeight=0 storeHeight=0
...
panic: unknown field "deployment_min_deposit" in v1beta3.Params

CUSTOM: state-sync sync test - OK 🟢

arno@x1:~$ helm upgrade --install akash-node ~/git/akash/helm-charts/charts/akash-node -n akash-services --set state_sync.enabled=true
arno@x1:~$ kubectl -n akash-services logs akash-node-1-0 --tail=10000 -f -c init |grep -iv p2p
...
INF Downloading trusted light block using options module=light
INF sync any module=statesync msg={}
INF Discovered new snapshot format=1 hash="��8j҄13E\f��B!���t��=��`{�+�\v�?S" height=13692500 module=statesync
INF Discovered new snapshot format=1 hash="��3�+�\x1f\x04��;�p\"����k]]nl��:�����R" height=13692000 module=statesync
INF Discovered new snapshot format=1 hash="��3�+�\x1f\x04��;�p\"����k]]nl��:�����R" height=13692000 module=statesync
...
INF Offering snapshot to ABCI app format=1 hash="��8j҄13E\f��B!���t��=��`{�+�\v�?S" height=13692500 module=statesync
INF Snapshot accepted, restoring format=1 hash="��8j҄13E\f��B!���t��=��`{�+�\v�?S" height=13692500 module=statesync
INF Fetching snapshot chunk chunk=0 format=1 height=13692500 module=statesync total=34
...
INF Fetching snapshot chunk chunk=13 format=1 height=13692500 module=statesync total=34
INF Fetching snapshot chunk chunk=14 format=1 height=13692500 module=statesync total=34
...
INF Applied snapshot chunk to ABCI app chunk=32 format=1 height=13692500 module=statesync total=34
INF Applied snapshot chunk to ABCI app chunk=33 format=1 height=13692500 module=statesync total=34
INF Verified ABCI app appHash="~6���B�n���1W�\x04,C�;��K���N�ٵ\x16�\x10" height=13692500 module=statesync
INF Snapshot restored format=1 hash="��8j҄13E\f��B!���t��=��`{�+�\v�?S" height=13692500 module=statesync
INF service start impl=BlockPool module=blockchain msg={}
INF minted coins from module account amount=3695545uakt from=mint module=x/bank
INF executed block height=13692501 module=state num_invalid_txs=0 num_valid_txs=0
INF commit synced commit=436F6D6D697449447B5B3233203733203832203234322032343820373620343520343820313938203131372031393620313030203233372038392031353520373420313334203934203133203132372037382031303420363520313236203930203139342039332032313620353020373020323033203131315D3A4430454535357D
INF committed state app_hash=174952F2F84C2D30C675C464ED599B4A865E0D7F4E68417E5AC25DD83246CB6F height=13692501 module=state num_txs=0
INF indexed block exents height=13692501 module=txindex

Copy link
Collaborator

@andy108369 andy108369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c29r3's snapshot is still bad - pre-0.26.2 (stuck at 13602143 height).

I've asked him to fix it.
Since it is not a default snapshot provider, I'll merge.

@andy108369 andy108369 merged commit 037b2fc into akash-network:main Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants