Gl 2039: Fixed mutants.

src/Command/CodeStudio/CodeStudioCiCdVariables.php

@@ -56,7 +56,7 @@ public static function getDefaultsForNode(?string $cloudApplicationUuid = NULL,
       ],
       [
         'key' => 'NODE_VERSION',
-        'masked' => FALSE,
+        'masked' => TRUE,
         'protected' => FALSE,
         'value' => $nodeVersion,
         'variable_type' => 'env_var',
@@ -106,7 +106,7 @@ public static function getDefaultsForPhp(?string $cloudApplicationUuid = NULL, ?
       ],
       [
         'key' => 'PHP_VERSION',
-        'masked' => FALSE,
+        'masked' => TRUE,
         'protected' => FALSE,
         'value' => $phpVersion,
         'variable_type' => 'env_var',

src/Command/CodeStudio/CodeStudioWizardCommand.php

@@ -45,15 +45,15 @@
     $phpVersion = NULL;
     $nodeVersion = NULL;
     $projectType = $this->getListOfProjectType();
-    $projectSelected = $this->io->choice('Select a project type', $projectType, $projectType[0]);
+    $projectSelected = $this->io->choice('Select a project type', $projectType, "Drupal_project");
 
     switch ($projectSelected) {
       case "Drupal_project":
         $phpVersions = [
             'PHP_version_8.1' => "8.1",
             'PHP_version_8.2' => "8.2",
           ];
-        $project = $this->io->choice('Select a PHP version', array_values($phpVersions), $phpVersions['PHP_version_8.1']);
+        $project = $this->io->choice('Select a PHP version', array_values($phpVersions), "8.1");
         $project = array_search($project, $phpVersions, TRUE);
         $phpVersion = $phpVersions[$project];
           break;
@@ -62,7 +62,7 @@
             'NODE_version_18.17.1' => "18.17.1",
             'NODE_version_20.5.1' => "20.5.1",
           ];
-        $project = $this->io->choice('Select a NODE version', array_values($nodeVersions), $nodeVersions['NODE_version_20.5.1']);
+        $project = $this->io->choice('Select a NODE version', array_values($nodeVersions), "18.17.1");
         $project = array_search($project, $nodeVersions, TRUE);
         $nodeVersion = $nodeVersions[$project];
           break;
@@ -210,16 +210,16 @@
     }
 
     foreach ($gitlabCicdVariables as $variable) {
-      $this->checklist->addItem("Setting CI/CD variable <comment>{$variable['key']}</comment>");
+      $this->checklist->addItem("Setting GitLab CI/CD variables for <comment>{$variable['key']}</comment>");
       if (!array_key_exists($variable['key'], $gitlabCicdExistingVariablesKeyed)) {
         $this->gitLabClient->projects()
           ->addVariable($project['id'], $variable['key'], $variable['value'], $variable['protected'], NULL, ['masked' => $variable['masked'], 'variable_type' => $variable['variable_type']]);
       }
       else {
         $this->gitLabClient->projects()
           ->updateVariable($project['id'], $variable['key'], $variable['value'], $variable['protected'], NULL, ['masked' => $variable['masked'], 'variable_type' => $variable['variable_type']]);
       }
       $this->checklist->completePreviousItem();
     }
   }
 

tests/phpunit/src/CommandTestBase.php

@@ -669,16 +669,6 @@ protected function getMockGitLabVariables(): array {
     ];
   }
 
-  /**
-   * @return array<mixed>
-   */
-  protected function getMockProjectTypeValue(): array {
-    return [
-      'Drupal_project',
-      'Node_project',
-    ];
-  }
-
   /**
    * Normalize strings for Windows tests.
    *

tests/phpunit/src/Commands/CodeStudio/CodeStudioCiCdVariablesTest.php

@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Acquia\Cli\Tests\Commands\CodeStudio;
+
+use Acquia\Cli\Command\CodeStudio\CodeStudioCiCdVariables;
+use Acquia\Cli\Tests\TestBase;
+
+class CodeStudioCiCdVariablesTest extends TestBase {
+
+  public function testGetDefaultsForNode(): void {
+    $codeStudioCiCdVariablesObj = new CodeStudioCiCdVariables();
+    $variables = $codeStudioCiCdVariablesObj->getDefaultsForNode();
+    $this->testBooleanValues($variables);
+    $variables = $codeStudioCiCdVariablesObj->getDefaultsForPhp();
+    $this->testBooleanValues($variables);
+  }
+
+  protected function testBooleanValues(array $variables): void {
+    foreach ($variables as $variable) {
+      $maskedValue = $variable['masked'];
+      $this->assertEquals(TRUE, $maskedValue);
+      $protectedValue = $variable['protected'];
+      $this->assertEquals(FALSE, $protectedValue);
+    }
+  }
+
+}

tests/phpunit/src/Commands/CodeStudio/CodeStudioWizardCommandTest.php

@@ -350,9 +350,13 @@ public function testCommand(array $mockedGitlabProjects, array $inputs, array $a
 
     /** @var Filesystem|ObjectProphecy $fileSystem */
     $fileSystem = $this->prophet->prophesize(Filesystem::class);
-    $this->mockGitlabProjectType($this->gitLabProjectId);
     // Set properties and execute.
     $this->executeCommand($args, $inputs);
+    $output = $this->getDisplay();
+    $output_strings = $this->getOutputStrings();
+    foreach ($output_strings as $output_string) {
+      self::assertStringContainsString($output_string, $output);
+    }
 
     // Assertions.
 
@@ -510,21 +514,12 @@ protected function mockGitLabNamespaces(ObjectProphecy $gitlabClient): void {
     $gitlabClient->namespaces()->willReturn($namespaces->reveal());
   }
 
-  protected function mockGitlabProjectType(int $gitlabProjectId): void {
-    $projectType = $this->getMockProjectTypeValue();
-    $this->assertCount(2, $projectType);
-  }
-
   protected function mockGitLabVariables(int $gitlabProjectId, ObjectProphecy $projects): void {
     $variables = $this->getMockGitLabVariables();
     $projects->variables($gitlabProjectId)->willReturn($variables);
     $projects->addVariable($gitlabProjectId, Argument::type('string'), Argument::type('string'), Argument::type('bool'), NULL, Argument::type('array'))->shouldBeCalled();
     foreach ($variables as $variable) {
       $projects->updateVariable($this->gitLabProjectId, $variable['key'], $variable['value'], FALSE, NULL, ['masked' => TRUE, 'variable_type' => 'env_var'])->shouldBeCalled();
-      $maskedValue = $variable['masked'];
-      $this->assertEquals(TRUE, $maskedValue);
-      $protectedValue = $variable['protected'];
-      $this->assertEquals(FALSE, $protectedValue);
     }
   }
 

tests/phpunit/src/Commands/WizardTestBase.php

@@ -153,4 +153,14 @@ protected function runTestSshKeyAlreadyUploaded(): void {
     $this->executeCommand();
   }
 
+  /**
+ * @return string[]
+ *   An array of strings to inspect the output for.
+ */
+  protected function getOutputStrings(): array {
+    return [
+      "Setting GitLab CI/CD variables for",
+    ];
+  }
+
 }