-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dockerfile for version 1.6.0 and a README.md for Docker usage #16
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: auzias <[email protected]>
I think this is interesting functionality and worth adding the simulator. However, the Dockerfile seems to fail due to mismatch in filenames |
Merge from the base project
The commit hash was appended at the end of the dirname of the untar document root. This created an error in during the `docker-build` procedure each time a new commit was pushed. To solve this the Dockerfile uses a wildcard.
Thanks for pointing out the error. The update should solve this. I'ld like to discuss whether or not the subdir |
Thanks! Now making the docker file works. Starting it fails though: Maybe the bash entrypoint actually makes more sense. On the directory/file structure; if we can avoid having multiple almost identical files (for each version), that would be good. Could we use same file for multiple versions and use just e.g. env variables? |
…PATH` I disagree on the entrypoint being `bash`. It is most likely that someone starting this image will be willing to run the-one and not bash. However, if `bash` is needed though it can still be started by using `docker run` option `--entrypoint=bash`.
The Dockerfile actually build the latest version of the-one, not the 1.6.0. Having the version as the tag is left out to the builder.
The last two commit should solve these issues. You may want to check the full |
Great work, works almost out of the box with just three small isuess: Java Image
MAINTAINER is deprecateduse Typo in working dirRunning it leads to an I might open a new pr containing a working version for linux and windows with wsl2 and docker soon |
Two files added:
Dockerfile
for the latest version (1.6.0) of the-ONE.README.md
to details the Docker usage.Feel free to suggest any modification.
Signed-off-by: auzias [email protected]