Extract method in SelfSigned #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The plan is to move the extracted function away so that we can build There is quite a few places/projects that have very similar needs (fake certs, trust stores built on-the-fly,...). The long term effort would solve #89 |
|
Travis said yes! |
dwijnand
reviewed
Sep 28, 2018
| tmf.init(keyStore) | ||
| val tms: Array[TrustManager] = tmf.getTrustManagers | ||
| val x509TrustManager: X509TrustManager = tms(0).asInstanceOf[X509TrustManager] | ||
|
|
||
| val kmf: KeyManagerFactory = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm) |
There was a problem hiding this comment.
@ignasi35 was the change from "SunX509" to KeyManagerFactory.getDefaultAlgorithm intentional?
There was a problem hiding this comment.
It was intentional and I think it's not significant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a noop change. extracts a method in preparation for a refactor that will eventually move this code to ssl-config.