test: Harden rollingupdate-kubernetes-cr-test.sh #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
Dec 5, 2023
•
patriknw
commented
- failing in CI
- I think it should wait for ready, not only running
- more error diagnostics
- jdk 17 image (seems to work)
- but main issue is the resource requuests with minikube
- argh, how many times are we going to run into this problem?
- update minikube and kubernetes versions
patriknw
force-pushed
the
wip-rolling-cr-patriknw
branch
2 times, most recently
from
87ca2c9 to
9c0e7c8
Compare
* failing in CI * I think it should wait for ready, not only running * more error diagnostics * jdk 17 image (seems to work) * but main issue is the resource requuests with minikube - argh, how many times are we going to run into this problem? * update minikube and kubernetes versions
patriknw
force-pushed
the
wip-rolling-cr-patriknw
branch
from
f6f8f47 to
60aaeef
Compare
|
after much trial and error I have found the real problem and fixed this |
johanandren
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.