feat: configurable choice of annotations for rolling update revision #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leviramsey
commented
Jul 25, 2024
| @@ -237,7 +237,7 @@ Java | |||
|
|
|||
| #### Configuration | |||
|
|
|||
| The following configuration is required, more details for each and additional configurations can be found in [reference.conf](https://github.com/akka/akka-management/blob/main/rolling-updates-kubernetes/src/main/resources/reference.conf): | |||
| The following configuration is required, more details for each and additional configurations can be found in [reference.conf](https://github.com/akka/akka-management/blob/main/rolling-update-kubernetes/src/main/resources/reference.conf): | |||
There was a problem hiding this comment.
Not sure how long the typo has been there...
I think the comment in reference.conf is sufficient documentation for a niche feature.
johanandren
reviewed
Jul 30, 2024
...g-update-kubernetes/src/main/scala/akka/rollingupdate/kubernetes/KubernetesJsonSupport.scala
Outdated
Show resolved
Hide resolved
| implicit val replicaAnnotationFormat: JsonFormat[ReplicaAnnotation] = jsonFormat1(ReplicaAnnotation.apply) | ||
| implicit val replicaAnnotationFormat: RootJsonFormat[ReplicaAnnotation] = | ||
| new RootJsonFormat[ReplicaAnnotation] { | ||
| // Not sure if we ever write this out, but if we do, this will let us write out exactly what we took in |
There was a problem hiding this comment.
Shouldn't we add the "writes" part only then if really need?
There was a problem hiding this comment.
Then we can even further simplify the case class ReplicaAnnotation.
There was a problem hiding this comment.
It's a JsonFormat so needs a writes. If we're going to implement it, we might as well implement it right
johanandren
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1302
Adds a config setting
akka.rollingupdate.kubernetes.revision-annotationto allow configurability (default is the prior behavior). From there it's just dealing with Spray JSON. Admittedly it's been a while (ever?) since I've done Spray JSON trickery, but (with apologies to Tolstoy) "all happy typeclass-and-AST JSON libraries are alike".I don't have a k8s cluster handy to test, mind.