Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: akka-http to 2.7.0-M1, akka to 2.10.0-M1, align with changes from upstream #1321

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

sebastian-alfers
Copy link
Contributor

No description provided.

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think the k8 test failure is related, it's probably flaky or something else broken with it in the env

@johanandren
Copy link
Member

I just merged another PR to main let's wait with merging this and see if the k8 test fails there as well

@sebastian-alfers
Copy link
Contributor Author

It succeeded on main?!

@sebastian-alfers
Copy link
Contributor Author

sebastian-alfers commented Sep 25, 2024

Uncaught error from thread [appka-akka.actor.default-dispatcher-4]: akka/util/JavaDurationConverters$JavaDurationOps$, shutting down JVM since 'akka.jvm-exit-on-fatal-error' is enabled for ActorSystem[appka]
java.lang.NoClassDefFoundError: akka/util/JavaDurationConverters$JavaDurationOps$
	at akka.management.HealthCheckSettings$.apply(HealthCheckSettings.scala:44)
	at akka.management.HealthCheckRoutes.<init>(HealthCheckRoutes.scala:26)

Taking a look.

@sebastian-alfers
Copy link
Contributor Author

It is this one: https://github.com/akka/akka-management/blob/main/samples/akka-sample-cluster-kubernetes-scala/build.sbt#L8

Should I revert the akka version on that build to make it pass, release an m1 of akka-management, and the bump the integration-tests?

@johanandren
Copy link
Member

Let's give that a shot.

@sebastian-alfers
Copy link
Contributor Author

That did it. Once we merge this, I make the M1 and will bump.

@johanandren johanandren merged commit 555ed88 into akka:main Sep 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants