Adds ApiMayChange and InternalApi - last round (#447)

* added last ApiMayChange and InternalApi * Apply suggestions from code review - adding line break
akka · Sep 10, 2020 · 9c4e0a4 · 9c4e0a4
1 parent 5846ce9
commit 9c4e0a4
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 5 deletions.
diff --git a/akka-projection-core/src/main/scala/akka/projection/MergeableOffset.scala b/akka-projection-core/src/main/scala/akka/projection/MergeableOffset.scala
@@ -4,4 +4,7 @@
 
 package akka.projection
 
+import akka.annotation.ApiMayChange
+
+@ApiMayChange
 final case class MergeableOffset[Offset](val entries: Map[String, Offset])
diff --git a/akka-projection-core/src/main/scala/akka/projection/ProjectionId.scala b/akka-projection-core/src/main/scala/akka/projection/ProjectionId.scala
@@ -6,8 +6,10 @@ package akka.projection
 
 import scala.collection.immutable
 
+import akka.annotation.ApiMayChange
 import akka.util.ccompat.JavaConverters._
 
+@ApiMayChange
 object ProjectionId {
 
   /**
@@ -85,6 +87,7 @@ object ProjectionId {
     keys.asScala.map { key: String => new ProjectionId(name, key) }.asJava
 }
 
+@ApiMayChange
 final class ProjectionId private (val name: String, val key: String) {
 
   require(name != null, "name must not be null")

diff --git a/akka-projection-core/src/main/scala/akka/projection/internal/ProjectionSettings.scala b/akka-projection-core/src/main/scala/akka/projection/internal/ProjectionSettings.scala
@@ -55,6 +55,7 @@ private[projection] object ProjectionSettings {
   }
 }
 
+@InternalApi
 private object RecoveryStrategyConfig {
   def fromConfig(config: Config): HandlerRecoveryStrategy = {
     val strategy = config.getString("strategy")

diff --git a/akka-projection-core/src/main/scala/akka/projection/javadsl/SourceProvider.scala b/akka-projection-core/src/main/scala/akka/projection/javadsl/SourceProvider.scala
@@ -30,10 +30,12 @@ abstract class SourceProvider[Offset, Envelope] {
 
 }
 
+@ApiMayChange
 trait VerifiableSourceProvider[Offset, Envelope] extends SourceProvider[Offset, Envelope] {
 
   def verifyOffset(offset: Offset): OffsetVerification
 
 }
 
+@ApiMayChange
 trait MergeableOffsetSourceProvider[Offset <: MergeableOffset[_], Envelope] extends SourceProvider[Offset, Envelope]
diff --git a/akka-projection-core/src/main/scala/akka/projection/scaladsl/SourceProvider.scala b/akka-projection-core/src/main/scala/akka/projection/scaladsl/SourceProvider.scala
@@ -28,10 +28,12 @@ trait SourceProvider[Offset, Envelope] {
 
 }
 
+@ApiMayChange
 trait VerifiableSourceProvider[Offset, Envelope] extends SourceProvider[Offset, Envelope] {
 
   def verifyOffset(offset: Offset): OffsetVerification
 
 }
 
+@ApiMayChange
 trait MergeableOffsetSourceProvider[Offset <: MergeableOffset[_], Envelope] extends SourceProvider[Offset, Envelope]
diff --git a/akka-projection-jdbc/src/main/scala/akka/projection/jdbc/internal/Dialect.scala b/akka-projection-jdbc/src/main/scala/akka/projection/jdbc/internal/Dialect.scala
@@ -239,8 +239,3 @@ END;
 
   override def updateStatement(): String = DialectDefaults.updateStatement(table)
 }
-
-/*
-
-
- */
diff --git a/akka-projection-slick/src/main/scala/akka/projection/slick/SlickProjection.scala b/akka-projection-slick/src/main/scala/akka/projection/slick/SlickProjection.scala
@@ -370,6 +370,7 @@ object SlickProjection {
     new SlickOffsetStore(system, databaseConfig.db, databaseConfig.profile, SlickSettings(system))
 }
 
+@ApiMayChange
 object SlickHandler {
 
   /** SlickHandler that can be define from a simple function */
-Original file line number
+Diff line change
@@ Expand Up / @@ -239,8 +239,3 @@ END; @@
       override def updateStatement(): String = DialectDefaults.updateStatement(table)
     }
-    /*
-     */