Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTP to file: remove course tool #37

Merged
merged 2 commits into from
Oct 3, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Sep 27, 2019

Remove course management sbt cruft from this single step example.

See #35

@seglo seglo self-requested a review October 2, 2019 15:56
Copy link
Contributor

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we collapse the sub projects into base as well.

@ennru
Copy link
Member Author

ennru commented Oct 3, 2019

No, I like them to be independent of each other. The docs project is OK to be a bit involved as it is for our eyes only.

@seglo
Copy link
Contributor

seglo commented Oct 3, 2019

I meant collapsing the sample project itself into one sbt project by combining step_001_complete, common, and base. AFAICT these sub projects are only to enable the training tool.

@ennru
Copy link
Member Author

ennru commented Oct 3, 2019

Alright, I kicked them out. Small and tidy now.

@seglo seglo self-requested a review October 3, 2019 14:12
Copy link
Contributor

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo merged commit 720aa00 into akka:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants