Fixed compilation issue with PostgreSQL 12 and C90 array size compata… #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility. Signed-off-by: Miguel Gomes <[email protected]>
|
@akorotkov some variant of this is (or disabling pg12's -Werror=vla setting https://github.com/postgres/postgres/blob/88709176236caf3cb9655acda6bad2df0323ac8f/configure.ac#L496 |
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Sep 13, 2020
PR: 248657 Reported by: [email protected] Obtained from: akorotkov/pgsphere#14 Sponsored by: BBOX.io git-svn-id: svn+ssh://svn.freebsd.org/ports/head@548447 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Sep 13, 2020
PR: 248657 Reported by: [email protected] Obtained from: akorotkov/pgsphere#14 Sponsored by: BBOX.io
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Sep 14, 2020
PR: 248657 Reported by: [email protected] Obtained from: akorotkov/pgsphere#14 Sponsored by: BBOX.io git-svn-id: svn+ssh://svn.freebsd.org/ports/head@548447 35697150-7ecd-e111-bb59-0022644237b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #12 and allows building against PostgreSQL 12 (at least on ArchLinux).
Tests passed and functionality seems okay.
Signed-off-by: Miguel Gomes [email protected]