Codecov giactions #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove old commented out code Co-authored-by: Alex Koshelev <[email protected]>
…us_network_test malicious network tests
In particular, this makes there be only one copy of the code that processes the input reports for an IPA query.
* Docker on Linux requires ARG defined for each layer * fix off-by-one error generating identity
Create tar files in the current directory rather than in scripts
On Linux it wasn't understood by tar and I ended up again with 10Gb+ context. Verified that this works on both MacOS and Linux
I believe after this I finally got it running on Linux
Reduce duplicated code involved in running a query
…onf-gen A script that generates 3 images
Replace `step::Descriptive` with type alias
This will take in 1. Reports in clear 2. Path to network.toml It will then initialize the helpers and send inputs for processing. Once submitted it waits for helpers to finish before returning with a result
See private-attribution#685 for details. We certainly need more than 256 streams. Having an upper limit close to that number leaves us vulnerable to having this issue again in the future. So I'd rather not limit it and rely on performance metrics if we start seeing impact of too many streams open. I also don't see an easy way to test this, so tests are not included :(
…ow generate events at a gap of upto 30 secs. This would ensure that we can test attribution window logic. We can easily generate events in > 14day attribution window with 100k query size with this.
0.14.20 has a bug hyperium/hyper#2419 that affects IPA
and make code compile
Remove the limit on number of concurrent streams
Upgrade dependencies
step attribute macro
* Use gate.as_ref() to print step names, rather than gate id
* Log reshare(vec) and shuffle steps
* Do not print IPA query config for every log line
```
ipa_query{query_config=IpaQueryConfig { per_user_credit_cap: 5, max_breakdown_key: 20, attribution_window_seconds: None, num_multi_bits: 3, plaintext_match_keys: false } query_size=500000}:sort_permutation:validate{gate=6939}: ipa::protocol::context::validator: new
```
is hard to read
Improve logging in IPA
Relax normal distribution bounds for DP test even more
Co-authored-by: Alex Koshelev <[email protected]>
…modulus-conversion Stream modulus conversion
I have some suspicion that not every panic is visible to our logs
It is hard to reason about the origin of http error if it is not seen in the error message
See private-attribution#758 for details
Enable HTTP2 PING for IPA connections
Add global panic hook and log destination endpoint
and Debug impl
These are mostly used to print errors, so allocations don't happen often
Otherwise, errors look like this
```
InfraError(ReceiveError { source: H1, step: "12287", inner: EndOfStream { record_id: RecordId(999424) } })
```
collect step tracing each time a step is narrowed
…e-log Use strings in Compact gate Display
…rt-groups Format code using group_imports=StdExternalCrate setting
This is an attempt to increase parallelism on CI. Those builds take ~4 mins and running tests take another 5-6 mins. Splitting this step should make CI run faster.
akoshelev
force-pushed
the
codecov-giactions
branch
from
d8a889e to
8934baa
Compare
akoshelev
force-pushed
the
codecov-giactions
branch
from
8934baa to
913a89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.