Skip to content
This repository has been archived by the owner on Oct 10, 2019. It is now read-only.

fixes compilation issues and supports larger samples #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixes compilation issues and supports larger samples #10

wants to merge 3 commits into from

Conversation

kobigurk
Copy link

  • compiles with ALLOW_MEMORY_GROWTH
  • exports functions
  • compiles with ASM_JS
  • removes SSE support from LAME to allow compilation
  • BUFSIZE is adjusted according to the size of the input channel, thus supports larger buffers

@kobigurk
exports, remove SSE, memory growth, asm.js
c19d79e 
* the export part is now required with recent versions of emscripten.
* the SSE instructions used by LAME are not supported by emscripten, causing the compilation to fail.
* allow memory growth to support larger buffers
* support asm.js
@kobigurk
BUFSIZE is adjusted according to input channel
daaa604
@kobigurk
new dist
b0253af
jasonm added a commit to minervaproject/user-media-recorder that referenced this pull request Dec 29, 2015
@jasonm
Update libmp3lame.js to @kobigurk fork per akrennmair/libmp3lame-js#10
b358a4f 
Prior prebuilt JS:
https://github.com/akrennmair/libmp3lame-js/blob/8645d01ec3f4ad0884f377068fd870678d0f6aaa/dist/libmp3lame.js

New prebuilt JS:
https://github.com/kobigurk/libmp3lame-js/blob/b0253af6bfd37ae0d88a1b9d498736b51f68f119/dist/libmp3lame.min.js
@jasonm jasonm mentioned this pull request Dec 29, 2015
Merged
BinaryMuse added a commit to minervaproject/user-media-recorder that referenced this pull request Dec 29, 2015
@BinaryMuse
Merge pull request #3 from minervaproject/update-libmp3lame-akrennmai…
346f190 
…r-issue-10

Update libmp3lame.js to @kobigurk fork per akrennmair/libmp3lame-js#10
@jasonm
Copy link

jasonm commented Dec 29, 2015

Just a note on context since we reference this from minervaproject/user-media-recorder#3 😃

We see issues with the libmp3lame.js from the master branch here (sha 8645d01) on Chrome 47 (current stable channel release) and Firefox 43 (current release) that are fixed by this PR. The issue is the process continually occupying 100+% CPU that can be traced to a webworker compressing 1 minute audio clips with libmp3lame.js. The issue is fixed by replacing with the build provided by @kobigurk here.

FWIW we see normal/expected CPU usage with the master version here in Chrome 48 (current beta channel) slated to release Jan 25, 2016 and Chrome 49 canary, so this issue will likely pass with time for most users.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobigurk @jasonm