Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Sundry updates per review #1101

Merged
merged 2 commits into from
Feb 10, 2025
Merged

📝 Sundry updates per review #1101

merged 2 commits into from
Feb 10, 2025

Conversation

akrherz
Copy link
Owner

@akrherz akrherz commented Feb 9, 2025

No description provided.

Copy link

deepsource-io bot commented Feb 9, 2025

Here's the code health analysis summary for commits 3aac26d..50e1027. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython❌ Failure
❗ 1 occurence introduced
View Check ↗
DeepSource PHP LogoPHP❌ Failure
❗ 1 occurence introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@akrherz
Copy link
Owner Author

akrherz commented Feb 10, 2025

Giving up on codecov, sigh

@akrherz akrherz merged commit 8b4ead6 into main Feb 10, 2025
10 of 12 checks passed
@akrherz akrherz deleted the 250209 branch February 10, 2025 00:22
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.93%. Comparing base (3aac26d) to head (50e1027).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pylib/iemweb/autoplot/scripts100/p109.py 80.00% 2 Missing ⚠️
pylib/iemweb/autoplot/scripts/p37.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   88.88%   88.93%   +0.04%     
==========================================
  Files         406      406              
  Lines       31173    31162      -11     
==========================================
+ Hits        27709    27714       +5     
+ Misses       3464     3448      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants