feat(gitprovider): setup gitea provider #3320
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Tchoupinax
force-pushed
the
feature/gitea-provider
branch
3 times, most recently
from
0ebb02c to
6baedc3
Compare
Tchoupinax
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3320 +/- ##
==========================================
+ Coverage 52.05% 52.48% +0.43%
==========================================
Files 295 292 -3
Lines 26695 26758 +63
==========================================
+ Hits 13895 14043 +148
+ Misses 12041 11941 -100
- Partials 759 774 +15 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tchoupinax <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Signed-off-by: Tchoupinax <[email protected]>
Tchoupinax
force-pushed
the
feature/gitea-provider
branch
from
6cafe76 to
b475805
Compare
|
In addition to my above comments, can you please update the documentation (nested in |
Co-authored-by: Hidde Beydals <[email protected]>
Co-authored-by: Hidde Beydals <[email protected]>
Co-authored-by: Hidde Beydals <[email protected]>
Co-authored-by: Hidde Beydals <[email protected]>
Co-authored-by: Hidde Beydals <[email protected]>
Co-authored-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
|
Tested this end-to-end, and caught and fixed a couple of bugs along the way. It works as expected now. |
| })) | ||
| } | ||
|
|
||
| baseURL := "https://" + host |
There was a problem hiding this comment.
This needs a double check @krancour. I "enforced" HTTPS here based on what we do for GitHub, but I am not sure that's what we want to do.
There was a problem hiding this comment.
I started to look at that a few days ago and got sidetracked. I'll assign myself to this so that I hopefully don't lose track.
Sorry for the delay.
- Prevent panic due to merge commit not existing at time of PR creation. - Use URL _including_ scheme to setup API client. - Make authentication actually work. - Use correct field for PR "number" (i.e. index). Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
feature/gitea-provider
branch
from
f718fb8 to
79de581
Compare
|
Thanks for your help! |
Hello,
As a big user of Gitea, I would love to have this provider included in Kargo!
Inspiration:
Closes #3321