Fix: Lights always report "on" state #2331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The is_on method (lines 244-251 in light.py) checks if prop_brightness is present and uses brightness_for_on to determine if the light is on. Even if the power property (on) is false, the brightness might exceed the threshold, causing an incorrect state. To skip the brightness check, add a condition in is_on to check if power_property is configured. Set a flag during initialization (like use_power_property) and use it to decide whether to use the parent class’s is_on (based on power) or the brightness-based check. The turn_on and turn_off methods in light.py (lines 253-335) may not correctly handle the power property when brightness settings are present. Added device customization should correctly map the power property and exclude brightness from influencing the state. Set ‘power_property’ to ‘on’ and ensure brightness isn’t included in properties that trigger the state check.
romanr
changed the title
|
It's been two releases and no merge. If you not going to merge this, just let me know, I will create my own fork. |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2313
The is_on method (lines 244-251 in light.py) to checs if prop_brightness is present and use brightness_for_on to determine if the light is on. Even if the power property (on) is false, the brightness might exceed the threshold, causing an incorrect state.
To skip the brightness check, added a condition in is_on to check if power_property is configured. Set a flag during initialization (like use_power_property) and use it to decide whether to use the parent class’s is_on (based on power) or the brightness-based check.
Fixed the turn_on and turn_off methods in light.py (lines 253-335) may not correctly handle the power property when brightness settings are present.
Added device customization to correctly map the power property and exclude brightness from influencing the state. Set ‘power_property’ to ‘on’ and ensure brightness isn’t included in properties that trigger the state check.