-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributor docs #267
Contributor docs #267
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 92.46% 92.48% +0.02%
==========================================
Files 62 62
Lines 3635 3635
==========================================
+ Hits 3361 3362 +1
+ Misses 274 273 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for putting the work in to integrate this with the existing guides. I have added a few minor comments.
I also suggest adding a note about the limitations around adding emulators that are expecting time-series data.
add contributing-emulators doc write contributing emulators docs add contributing docs update contributing emulator docs
update README
Update CONTRIBUTING.md Co-authored-by: Sophie Arana <[email protected]> Update CONTRIBUTING.md Co-authored-by: Sophie Arana <[email protected]> Update CONTRIBUTING.md Co-authored-by: Sophie Arana <[email protected]>
Co-authored-by: Sophie Arana <[email protected]>
Co-authored-by: Sophie Arana <[email protected]> Update docs/community/contributing-emulators.md Co-authored-by: Sophie Arana <[email protected]> Update docs/community/contributing-emulators.md Co-authored-by: Sophie Arana <[email protected]> Update docs/community/contributing-emulators.md Co-authored-by: Sophie Arana <[email protected]>
8f6071d
to
882ac35
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I am happy for this to be merged |
Co-authored-by: Sophie Arana <[email protected]>
goals:
contributing-emulators.md
contributing-docs.md