Skip to content

Commit

Permalink
fix(ci): comment out docker compose volume mount for permission
Browse files Browse the repository at this point in the history
  • Loading branch information
spool committed Dec 11, 2023
1 parent f69a387 commit 8cdeea2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
run: |
docker compose build jupyter
docker compose up jupyter --detach
docker compose exec jupyter bash -c "conda run -n $CONDA_ENV_NAME --cwd python pytest -p no:sugar"
docker compose exec jupyter bash -c "conda run -n $env_name --cwd python pytest pytest"
export JUPYTER_ID=$(docker compose ps -q jupyter)
echo "jupyter_id=$JUPYTER_ID" >> $GITHUB_ENV
echo "jupyter_id=$JUPYTER_ID"
Expand Down
4 changes: 2 additions & 2 deletions compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ services:
target: clim-recal-base
ports:
- "8888:8888"
volumes:
- .:/home/jovyan:rw
# volumes:
# - .:/home/jovyan:rw

docs:
build:
Expand Down
5 changes: 3 additions & 2 deletions compose/jupyter/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ RUN "${CONDA_DIR}/envs/${env_name}/bin/python" -m ipykernel install --user --nam
fix-permissions "/home/${NB_USER}"

# Copy the rest of the clim-recal code to volume
COPY --chown=${NB_UID}:${NB_GID} . .

# COPY --chown=${NB_UID}:${NB_GID} . .
# Keep below while permission ambiguity persists on compose volume mounting
COPY . .

# Switch to default jupyter user
# USER ${NB_UID}
Expand Down

0 comments on commit 8cdeea2

Please sign in to comment.