Remove debiasing folder #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuthBowyer
approved these changes
Nov 25, 2024
|
Still todo; update |
|
Question for @RuthBowyer do we want to keep any of these files?:
|
This removes the instructions for running integration tests, which rely on data on the fileshare, in anticipation of that resource being deleted in the near future. It also removes some historical references to cmethods.
|
@sgreenbury Please could you have a quick look at the updated |
sgreenbury
reviewed
Nov 27, 2024
docs/contributing.md
Outdated
| @@ -97,7 +95,9 @@ isort (python)...........................................................Passed | |||
|
|
|||
| # Running tests | |||
|
|
|||
| Currently, only the `python` portions of `clim-recal` have unit tests, and some of those require direct access to `ClimateData` mounted on `/mnt/vmfileshare/ClimateData` (which matches our configuration on `linux`). There are ways of running those tests locally if you are able to mount the `ClimateData` drive to that path, either via `conda` or `docker` (`conda` if running `linux`, in theory any operating system if running `docker`). We will expand the details of this process in future, but for tests that do not require `ClimateData`, the instructions for running those are below: | |||
| Only some portions of the python `clim-recal` code has unit tests. Additionally there are integration tests which require direct access to [the data](/README#the-datasets) mounted on the hardcoded path `/mnt/vmfileshare/ClimateData` (which matches our configuration on `linux`). There are ways of running those integration tests locally if you are able to mount the `ClimateData` drive to that path, either via `conda` or `docker` (`conda` if running `linux`, in theory any operating system if running `docker`). | |||
There was a problem hiding this comment.
Perhaps it could be useful to add a link (or the pytest markers) for the integration tests mentioned here?
The updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.