warning: `if` chain can be rewritten with `match` --> trustchain-ion/src/utils.rs:371:9 | 371 | / if current_unixtime as i64 > target_unixtime { 372 | | end_height = current_height; // TODO CHECK: original script has: current_height - 1; 373 | | } else if (current_unixtime as i64) < target_unixtime { 374 | | start_height = current_height; // TODO CHECK: original script has: current_height + 1; 375 | | } | |_________^ | = help: consider rewriting the `if` chain to use `cmp` and `match` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain = note: `#[warn(clippy::comparison_chain)]` on by default

warning: redundant closure --> trustchain-ion/src/utils.rs:95:22 | 95 | .map_err(|err| TrustchainIpfsError::Utf8DecodingError(err))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `TrustchainIpfsError::Utf8DecodingError` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default

warning: this pattern creates a reference to a reference --> trustchain-ion/src/resolver.rs:195:22 | 195 | .filter_map(|ref s| { | ^^^^^ help: try: `s` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: derefed type is same as origin --> trustchain-ion/src/resolver.rs:196:16 | 196 | if s.type_ | ________________^ 197 | | .to_single() 198 | | .as_deref() | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref = note: `#[warn(clippy::needless_option_as_deref)]` on by default help: try | 196 ~ if s.type_ 197 + .to_single() |

warning: single-character string constant used as pattern --> trustchain-core/src/resolver.rs:302:33 | 302 | .rsplit(":") | ^^^ help: try using a `char` instead: `':'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `#[warn(clippy::single_char_pattern)]` on by default