Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verifiable presentation API for ION attestor #116

Merged
merged 28 commits into from
Sep 6, 2023
Merged

Verifiable presentation API for ION attestor #116

merged 28 commits into from
Sep 6, 2023

Conversation

edchapman88
Copy link
Collaborator

@edchapman88 edchapman88 commented Sep 4, 2023 •
edited by sgreenbury
Loading

Closes #59.

sgreenbury and others added 13 commits July 28, 2023 17:32
@sgreenbury
Initial TrustchainVPAPI, holder trait, presentation error
aaf24bb
@sgreenbury
Merge branch '79-refactor-api' into 79-refactor-api-vp
1f79504
@edchapman88
concurrently verify iterator over CredentialOrJWT with type annotatio…
079699e 
…n bug
@edchapman88 @sgreenbury @lukehare
bug fix stream processing for verify_presentation
bccb29e 
Co-authored-by: Sam Greenbury <[email protected]>
Co-authored-by: lukehare <[email protected]>
@edchapman88
unit test verify_credential and verify_presentation
a217791
@edchapman88 @sgreenbury @pwochner
Add verification for holders signature
95763c0 
Co-authored-by: Sam Greenbury <[email protected]>
Co-authored-by: pwochner <[email protected]>
@edchapman88
add TODO for holder field on Presentation before signing
467ffd4
@edchapman88
verify holder's DID
c3c7c59
@edchapman88
check if holder field is populated on presentation before signing
e01aa5d
@edchapman88
attempt to support unauthorised or unverified holders
07d41d8
@sgreenbury
Remove trustchain verification on holder
6c42fd7
@sgreenbury
Merge branch 'main' into 59-vp-api
56984d6
@sgreenbury
Add todo for init function for tests
710a7e8
@edchapman88 edchapman88 linked an issue Sep 4, 2023 that may be closed by this pull request
Implement issuing a verifiable presentation #59
Closed
sgreenbury
sgreenbury approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@sgreenbury sgreenbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sgreenbury sgreenbury changed the title 59 vp api Verifiable presentation API for ION attestor Sep 6, 2023
@edchapman88 edchapman88 merged commit ca915a6 into main Sep 6, 2023
5 checks passed
@edchapman88 edchapman88 deleted the 59-vp-api branch September 6, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgreenbury sgreenbury sgreenbury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement issuing a verifiable presentation
2 participants
@edchapman88 @sgreenbury