Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Challenge-response for attestation #162

Merged
merged 95 commits into from
Oct 7, 2024
Merged

Challenge-response for attestation #162

merged 95 commits into from
Oct 7, 2024

Conversation

pwochner
Copy link
Collaborator

@pwochner pwochner commented Dec 4, 2023

Functionality and cli for challenge-response process for attestation.
Closes #94

pwochner added 30 commits May 26, 2023 17:11
Add attestor module. Add route for initiating attestation.
26ff481
Merge branch '55-issuer-backend-traits' into 94-challenge-response
40c7ff4
Add functionality to create directory for attestation request and wri…
495ed12 
…te attestation info to file.
Add functionality to handle initial attestation request.
955185f
Add script to play with josekit for nonce encryption.
d8b3706
Add functionality to sign encrypted nonce, verify signature and decry…
861dad8 
…pt it.
Conversion between ssi JWK and josekit Jwk type.
b2a5370
Refactor functionality for identity CR.
02e1601
Test for content CR
7c04f02
Add generate/verify response to content CR.
9f2592c
Types and traits for identity CR, signing and encrypting.
204cd2a
Add test did document and keys for CR.
7283cf4
Test content CR on multiple signing keys.
ddc554e
Types and traits for CR. Test for content CR.
e6c9a81
Implement writing identity CR struct to json file.
d7bef94
Make json read-only. Ignore None fields.
683fb0f
Implement elementwise deserialisation for CR.
4654c2e
Improve elementwise serialise.
6af4e4a
Error handling of elementwise deserialisation for initiation: throw e…
7394017 
…rror if deserialize fails, but not if file doesn't exist. Improve tests.
Error handling of elementwise deserialisation for identity and conten…
1759fc0 
…t CR.
Return none for elementwise_deserialize() if none of the files exist.
2e0ebf8
Don't overwrite file if already exists for elementwise serialize.
25a2f07
Adds status check for challenge response.
8332cea
Use enum for checking CR status. Add struct for Content CR Initiation…
1bb4e6c 
…. More tests.
Remove unused code. Improve messages for CR status check.
f1f6789
Add docstrings.
45ebe84
Merge branch 'main' into 94-challenge-response
3724097
Add initiate identity CR to Trustchain cli.
e7d19e2
Refactor challenge response functionality.
0b01d2d
Attestor: remove unused functionality. Modify functionality to post i…
33fe5d0 
…nitiation request.
@sgreenbury
Copy link
Collaborator

Some notes on fixing the error when using impl IntoResponse in return type:

  • From axum docs, -> Result<impl IntoResponse, TrustchainHTTPError> appears to work well to enable propagating the errors with ? (see axum docs)
  • The handler (TrustchainAttestorHTTPHandler::post_identity_response) appears to have a different error

@sgreenbury sgreenbury mentioned this pull request Sep 16, 2024
Merged
@sgreenbury sgreenbury mentioned this pull request Oct 4, 2024
Merged
thobson88
thobson88 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@thobson88 thobson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pwochner pwochner merged commit d7cb63d into main Oct 7, 2024
5 checks passed
@pwochner pwochner deleted the 94-cr-cli branch October 7, 2024 15:24
This was referenced Oct 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgreenbury sgreenbury sgreenbury left review comments

@thobson88 thobson88 thobson88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Challenge response protocol
3 participants
@pwochner @thobson88 @sgreenbury