CLI status command #214
Open
CLI status command #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgreenbury
reviewed
Nov 5, 2024
| @@ -189,6 +196,10 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| let resolver = verifier.resolver(); | |||
| let mut context_loader = ContextLoader::default(); | |||
| match matches.subcommand() { | |||
| Some(("status", _)) => { | |||
| // TODO: update the trustchain-api crate. | |||
There was a problem hiding this comment.
Remove comment as currently not required beyond use in this CLI
Suggested change
| // TODO: update the trustchain-api crate. |
sgreenbury
reviewed
Nov 5, 2024
Comment on lines
+412
to
+414
| #[derive(Debug)] | ||
| pub enum BitcoindStatus { | ||
| Ok(bool), |
There was a problem hiding this comment.
Could use an enum instead of bool:
Suggested change
| #[derive(Debug)] | |
| pub enum BitcoindStatus { | |
| Ok(bool), | |
| // TODO: update to enum provided by rust-bitcoin latest version | |
| pub enum BitcoinNetwork { | |
| Mainnet, | |
| Testnet | |
| } | |
| #[derive(Debug)] | |
| pub enum BitcoindStatus { | |
| Ok(BitcoinNetwork), |
sgreenbury
reviewed
Nov 5, 2024
| pub async fn print_status() { | ||
| let bitcoind_status = bitcoind_status().await; | ||
| let mut is_mainnet = false; | ||
| if let BitcoindStatus::Ok(x) = bitcoind_status { |
There was a problem hiding this comment.
As discussed could also check if the bitcoin network running matches the CLI's ION network with something like:
use trustchain_ion::ion::IONTest as ION;
if (ION::NETWORK == "" && !is_mainnet) || (ION::NETWORK == "test" && is_mainnet) {
println!("Wrong bitcoin network running: {}");
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #206.
Adds a new
statussubcommand that reports the status of the local ION node.