Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump teslajsonpy to 3.12.2 #1067

Closed
wants to merge 10 commits into from
Closed

Conversation

ehendrix23
Copy link
Contributor

Bump teslajsonpy to 3.12.2 which includes fix for API service

@ehendrix23 ehendrix23 changed the title Bump teslajsonpy to 3.12.2 Fix: Bump teslajsonpy to 3.12.2 Nov 22, 2024
@ehendrix23 ehendrix23 changed the title Fix: Bump teslajsonpy to 3.12.2 fix: Bump teslajsonpy to 3.12.2 Nov 22, 2024
@alandtse
Copy link
Owner

Please review other bumps. Other files will also also need to be changed.

@ehendrix23
Copy link
Contributor Author

Updated the additional files. Not sure why the test would fail though as nothing there has been changed.

@alandtse
Copy link
Owner

Someone probably broke the test with a commit.

@ehendrix23
Copy link
Contributor Author

Someone probably broke the test with a commit.

Found reason for both tests that failed:

  1. PR fix: update entity with HA 2024.11 #1069 fixes the issue where in_progress returns True. This is because in_progress requires a boolean and not a number, update_percentage instead should be used for percentage.
  2. PR #479 in teslajsonpy fixes the issue when both a websession and a certificate is provided. This would then result in bump for teslajsonpy and hence will update this commit with new version once released.

@ehendrix23 ehendrix23 marked this pull request as draft November 25, 2024 16:24
@alandtse
Copy link
Owner

Thanks for figuring that out. Is the other PR #1069 a prereq of this? Normally I'd want to keep the test fix as a separate PR so the bump PR is very clean.

@ehendrix23
Copy link
Contributor Author

Thanks for figuring that out. Is the other PR #1069 a prereq of this? Normally I'd want to keep the test fix as a separate PR so the bump PR is very clean.

Nope, no dependencies. PR #1069 was purely to update for HA 2024.11 and had nothing to do with teslajsonpy. :-)

FYI, seems I screwed some things up so closing this PR for the bump and creating a new one instead that is clean. :-)

@ehendrix23 ehendrix23 closed this Nov 26, 2024
@ehendrix23 ehendrix23 deleted the patch-1 branch November 26, 2024 14:21
@@ -5,11 +5,11 @@

import logging

import voluptuous as vol
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did black do this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say yes, I didn't add it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants