test: Fix tests #753
Merged
test: Fix tests #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hass.services.async_call no longer returns a boolean, as documented here: https://developers.home-assistant.io/blog/2023/06/14/service-calls/ Also add some keys to the mock data.
|
Thanks for doing that. Modifying mock is fine as long as they actually logically make sense still as a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the tests!
Most tests just had a broken
hass.services.async_call.hass.services.async_callno longer returns a boolean, as documented here:https://developers.home-assistant.io/blog/2023/06/14/service-calls/
Fix: just don't look at the return value anymore.
However, some tests fail due to mismatch in mock data and teslajsonpy and/or extraction code in
sensor.py.I have fixed them by modifying the mock data.
Not sure if that is the correct approach. Are there recent examples of SolarPowerwallSite responses?