Fix data race in BufferedRuntimeExecutor (facebook#45512)

Summary: Pull Request resolved: facebook#45512 isBufferingEnabled_ can be read (by design) from multiple threads, but it's not atomic. Make it so. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D59907026 fbshipit-source-id: ffce54a28404148b3e270fa90dfe850a334ca2f0
alanleedev · Jul 18, 2024 · a37534e · a37534e
1 parent fbcb8f6
commit a37534e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/react-native/ReactCommon/react/runtime/BufferedRuntimeExecutor.h b/packages/react-native/ReactCommon/react/runtime/BufferedRuntimeExecutor.h
@@ -41,7 +41,7 @@ class BufferedRuntimeExecutor {
   void unsafeFlush();
 
   RuntimeExecutor runtimeExecutor_;
-  bool isBufferingEnabled_;
+  std::atomic<bool> isBufferingEnabled_;
   std::mutex lock_;
   std::atomic<uint64_t> lastIndex_;
   std::priority_queue<BufferedWork> queue_;