Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Added in PSK authentication #8

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

alisalama
Copy link

Hi Alan,

I've added in the functionality to authenticate with the Pre-Shared Key (PSK), this basically bypasses having to authenticate using cookies everytime.

I've left all the cookie authentication stuff in there so if no PSK is provided then that can still be used.

Also using PSK authentication fixes the bug of repeating authentication issues mentioned in #4, #5 & #7.

Thanks,
Ali

@alanreid
Copy link
Owner

Hey Ali,

This is awesome, thank you!!

Is there any way you could make both cookies and PSK auth work? Because as far as I saw, this would break cookie-based auth. It would be great if it would use PSK as default and only use cookie-based auth if you don't specify a PSK key.

Other than that, this looks great. I have no way to test it, but we can ask the other guys having issues to take a look.

Best,
Alan

@alisalama
Copy link
Author

I need to double check, but I thought I left it so that if you don't specify a PSK then it defaults back to use the cookies authentication.

I'm also working on wrapping it in a nodejs server with some route mapping, to use with an Amazon Echo.

@cevatkerim
Copy link

This works just fine.

@arnif
Copy link

arnif commented Dec 26, 2016

This works perfectly. Thank you ❤️

@alanreid
Copy link
Owner

alanreid commented Jan 3, 2017

Hi guys,

Thank you all for your input! I just merged @alisalama's changes to master, since you all seem to agree that it's working. As said, I no longer own a Bravia TV, so unfortunately I can't test this myself 😞

@alisalama: There was a conflict while merging, so I had to manually solve it. Can you please check it all works whenever you have a minute?

Thanks a lot again!

Best,
Alan

@arnif
Copy link

arnif commented Jan 5, 2017

Can confirm this works, although express is missing as dependency and the README.md needs to be updated. I can submit a PR for that this weekend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants