Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rspec deprecation #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix rspec deprecation #7

wants to merge 1 commit into from

Conversation

glittershark
Copy link
Contributor

@albertosaurus
Copy link
Owner

This unfortunately fails in Travis. Please fix and I'll take another look. Thanks!

@glittershark
Copy link
Contributor Author

Looks like the issue here (and the deprecation issue in the first place) is an Rspec 2 vs 3 thing. I tried upgrading Rspec in this library to 3.x but genspec >= 2.0, which you're using, doesn't support Rspec 3. I checked out genspec and it looks pretty dead (last commit Nov 5 2013), any thoughts about ripping out that dependency entirely?

@albertosaurus
Copy link
Owner

'genspec' gave me many a problem throughout the ages (I had to fork it at one point), but there's nothing else that lets you test generators. I may need to live off a fork again. Unfortunately, I'm supervising a client through a major rollout right now, so it'll have to wait a week or two.

@glittershark
Copy link
Contributor Author

I've got some time this weekend, I'll see if I can take a crack at it then.

@kmwhite kmwhite mentioned this pull request Mar 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glittershark @albertosaurus