-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time reverse #2121
Add time reverse #2121
Conversation
Reviewer's Guide by SourceryThis PR introduces a new TimeReverse transform for spectrogram augmentation, which is implemented as a subclass of HorizontalFlip. The implementation includes necessary test updates and documentation changes. The PR also includes some cleanup in the test_targets.py file by simplifying the DUAL_TARGETS dictionary. Class diagram for the new TimeReverse transformclassDiagram
class HorizontalFlip {
+p: float
+always_apply: bool | None
}
class TimeReverse {
+p: float
+always_apply: bool | None
}
TimeReverse --|> HorizontalFlip
note for TimeReverse "TimeReverse is a subclass of HorizontalFlip, providing a semantically meaningful name for spectrograms."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2121 +/- ##
=========================================
+ Coverage 0 90.24% +90.24%
=========================================
Files 0 47 +47
Lines 0 7718 +7718
=========================================
+ Hits 0 6965 +6965
- Misses 0 753 +753 ☔ View full report in Codecov by Sentry. |
Fixes: #2119
Summary by Sourcery
Add a new 'TimeReverse' transformation for spectrogram images, which reverses the time axis similar to a horizontal flip. Update documentation to reflect this addition and include tests to verify its functionality.
New Features:
Enhancements:
Tests: