Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add uo perms and trusted uo submission #1037

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dancoombs
Copy link
Collaborator

@dancoombs dancoombs commented Feb 25, 2025

Proposed Changes

  • Add an optional field to the end of eth_sendUserOperation to represent user operation permissions
  • Add the first permission, trusted, which allows the UO to use unsafe simulation

TODO:

  • Unit tests
  • Local testing
  • Docs

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 84.39024% with 64 lines in your changes missing coverage. Please review.

Project coverage is 60.32%. Comparing base (a09df4a) to head (79e0dc6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/rundler/src/cli/rpc.rs 0.00% 18 Missing ⚠️
crates/pool/src/server/remote/protos.rs 0.00% 12 Missing ⚠️
crates/rpc/src/task.rs 0.00% 8 Missing ⚠️
crates/rpc/src/eth/api.rs 77.41% 7 Missing ⚠️
crates/rpc/src/eth/server.rs 0.00% 6 Missing ⚠️
crates/pool/src/server/remote/server.rs 0.00% 5 Missing ⚠️
crates/rpc/src/types/permissions.rs 0.00% 5 Missing ⚠️
crates/pool/src/server/remote/client.rs 0.00% 2 Missing ⚠️
bin/rundler/src/cli/node/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
bin/rundler/src/cli/mod.rs 0.00% <ø> (ø)
crates/builder/src/bundle_proposer.rs 93.22% <100.00%> (+0.30%) ⬆️
crates/pool/src/mempool/mod.rs 100.00% <100.00%> (ø)
crates/pool/src/mempool/paymaster.rs 93.19% <100.00%> (+<0.01%) ⬆️
crates/pool/src/mempool/pool.rs 97.19% <100.00%> (+<0.01%) ⬆️
crates/pool/src/mempool/uo_pool.rs 93.49% <100.00%> (+0.14%) ⬆️
crates/pool/src/server/local.rs 49.08% <100.00%> (+1.55%) ⬆️
crates/rpc/src/types/mod.rs 12.28% <ø> (ø)
crates/rpc/src/types/v0_6.rs 26.86% <ø> (ø)
crates/sim/src/simulation/mod.rs 43.75% <ø> (ø)
... and 15 more

... and 1 file with indirect coverage changes

Flag Coverage Δ
unit-tests 60.32% <84.39%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 68.30% <100.00%> (+0.64%) ⬆️
dev ∅ <ø> (∅)
pool 67.85% <87.24%> (+0.14%) ⬆️
provider 20.17% <ø> (ø)
rpc 26.42% <48.00%> (+0.56%) ⬆️
sim 81.31% <100.00%> (+1.00%) ⬆️
tasks ∅ <ø> (∅)
types 67.40% <100.00%> (+0.58%) ⬆️
utils 32.43% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant