Remove editlevels #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated ALDOR_F_LibExportNotFound error message and allows AXL_ as well as ALDOR_ message prefixes
This edit has been turned into a compiler option: -Wnew-hcodes Here is the comment from editlevels.h: Edit level AXL_EDIT_1_1_13_18 has been returned to the list of active edits. It still causes problems for Basicmath DUP, but it solves the issue where maps and packed maps were being given the same hash value when the only difference in the maps was the position of the map symbol. For example (I, I) -> (I, I) was getting the same hash code as (I) -> (I, I, I) and (I, I, I) -> (I). The problem with Basicmath DUP can be seen when * is applied to acc and result in CantorZassenhausFactorizationPackage (located in $BMROOT/src/polypkg/factorczpkg.as). When acc is ? and result is 1, (both acc and result being of type U), the multiply invoked is (r: R) * (x : %) : % rather than (x : %) * (y : %) : %. This results in a large integer times ? being returned, rather than 1*?. Applying this edit appears to be revealing another bug in the compiler that has yet to be isolated to a simple test case. (The Basicmath DUP behaviour is illustrated by Basicmath test duptest19.as). It does not appear to be a result of a hash code collision under the new system as several alternative code computations were tried providing the same result.
|
Are you going to merge these changes? - they look good to me (although Peter |
|
yes, I was waiting for someone to review them before I do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #21.