Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying go version across files #87

Closed
alegrey91 opened this issue Feb 8, 2025 · 2 comments · Fixed by #88
Closed

Unifying go version across files #87

alegrey91 opened this issue Feb 8, 2025 · 2 comments · Fixed by #88
Assignees
Labels
ci/cd Something about CI/CD good first issue Good for newcomers

Comments

@alegrey91
Copy link
Owner

alegrey91 commented Feb 8, 2025

Currently we are specifying the go version in several files in the codebase:

  • go.mod file
  • Dockerfile base image for the build
  • .github/workflows/* when we install go through the github actions
  • Probably somewhere else

To avoid a version misalignments, we should fix the way we set the go version in all the files listed above.
The single source of truth could be the go.mod file, so that the other files can retrieve the go version from there.
Additionally, I'm thinking to remove the building stage from the Dockerfile and use it just to COPY the harpoon artifact inside of it once built outside.
This will simplify the process and make the build unique.

@alegrey91 alegrey91 added ci/cd Something about CI/CD good first issue Good for newcomers labels Feb 8, 2025
@Mughees2001
Copy link
Contributor

Hello, I would like to work on this problem

@alegrey91
Copy link
Owner Author

Hello @Mughees2001, you are welcome!
If you need some clarification about the issue feel free to ask :)
We can also arrange a meeting if you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Something about CI/CD good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants