Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for new pricing system #199

Merged
merged 16 commits into from
Feb 18, 2025
Merged

Changes for new pricing system #199

merged 16 commits into from
Feb 18, 2025

Conversation

philogicae
Copy link
Member

@philogicae philogicae commented Jan 31, 2025 •
edited
Loading

Jira: ALEPH-393, ALEPH-397, ALEPH-400

Needed for this PR on SDK

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Update TODO lines for PROD

Changes

  • Move/improve flow code parts from CLI to SDK
  • Add utils functions
  • Add make_instance_content and make_program_content
  • Refactor create_instance and create_program
  • Add get_estimated_price
  • Fixes for mypy/ruff/pytest
  • Minor improvements
  • Remove firecracker rootfs hashes for instances

@philogicae philogicae requested a review from nesitor January 31, 2025 14:46
@github-actions github-actions bot added the RED This PR is complex and may require more time to review. label Jan 31, 2025
@philogicae philogicae self-assigned this Jan 31, 2025
@philogicae philogicae force-pushed the add-manage-flow-superfluid branch from f3cc2ba to fa60a8a Compare January 31, 2025 17:23
@philogicae philogicae force-pushed the add-manage-flow-superfluid branch from 813cf75 to a401698 Compare February 3, 2025 09:33
nesitor
nesitor previously approved these changes Feb 4, 2025
View reviewed changes
@philogicae philogicae mentioned this pull request Feb 4, 2025
Merged
21 tasks
@philogicae philogicae force-pushed the add-manage-flow-superfluid branch 2 times, most recently from 8e891e1 to 13be020 Compare February 6, 2025 16:22
@philogicae philogicae force-pushed the add-manage-flow-superfluid branch from 13be020 to 30190e6 Compare February 6, 2025 17:26
@philogicae philogicae changed the title Add manage_flow to superfluid.py Changes for new pricing system Feb 6, 2025
@philogicae philogicae force-pushed the add-manage-flow-superfluid branch from 9e7f24d to 9139e20 Compare February 6, 2025 17:36
@philogicae philogicae force-pushed the add-manage-flow-superfluid branch 5 times, most recently from 904c4c6 to d310a69 Compare February 13, 2025 12:17
@philogicae philogicae force-pushed the add-manage-flow-superfluid branch from d310a69 to 97ac509 Compare February 13, 2025 12:48
@aleph-im aleph-im deleted a comment from github-actions bot Feb 18, 2025
@philogicae philogicae merged commit e4ce90e into main Feb 18, 2025
22 checks passed
@philogicae philogicae deleted the add-manage-flow-superfluid branch February 18, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesitor nesitor nesitor approved these changes

Assignees

@philogicae philogicae

Labels
RED This PR is complex and may require more time to review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philogicae @nesitor