add caching for ssm parameters and datadog values #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else: | ||
| raise AlEnvException() from e | ||
|
|
||
| self._setup_aws_resources(source) | ||
|
|
||
| def get(self, key, default=None, format='decoded', type=None): |
There was a problem hiding this comment.
Perhaps this should be get_from_dynamodb, and the other should be get_from_ssm - as it's not clear just looking at
alertlogic-sdk-python/almdrlib/config.py
Lines 119 to 128 in 6f49dbf
|
|
||
| def _make_ssm_key(self, option_key): | ||
| return f"/deployments/{self.stack_name}/{self._get_region()}/env-settings/{self.application_name}/{self._make_client_option_key(option_key)}" | ||
| return f"/deployments/{self._get_stack_name()}/{self._get_region()}/env-settings/{self.application_name}/{self._make_client_option_key(option_key)}" |
There was a problem hiding this comment.
Would you mind adding to https://github.com/alertlogic/alertlogic-sdk-python#readme the paths we search for in dynamodb / ssm.
Also, it's probably future work, but it would be nice to be able to specify those paths in ~/.alertlogic/config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue with too many Session objects being created, and pulling AIMS credentials from SSM every time. This change adds caching for parameters pulled from SSM and values pulled from datadog.