-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP ]Filter the logs base on logNames and timestamps #379
[GCP ]Filter the logs base on logNames and timestamps #379
Conversation
CI Service Job Number 1047 Logs - SUCCESS
Stages Run:
|
CI Service Job Number 1048 Logs - SUCCESS
Stages Run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes! +1 from me
0e0cbda
to
edca08b
Compare
CI Service Job Number 1049 Logs - SUCCESS
Stages Run:
|
CI Service Job Number 1050 Logs - SUCCESS
Stages Run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Rakhi, looks good; just one minor comment and one question from me
CI Service Job Number 1055 Logs - SUCCESS
Stages Run:
|
CI Service Job Number 1056 Logs - SUCCESS
Stages Run:
|
9a5fb66
to
26f5c6c
Compare
CI Service Job Number 1062 Logs - SUCCESS
Stages Run:
|
build-collector-googlestackdriver |
CI Service Job Number 1063 Logs - SUCCESS
Stages Run:
|
Problem Description
Currently there is no functionality to filter the logs base on log names and collector pull all type of logs
Solution Description
Apply filtering based on the provided logName values,
So that the system fetches only the relevant logs, or all logs if no logName is provided, using the GCP Logging API.
Acceptance Criteria for Contributors
It will encode the Log name URI if it is not encoded. It will accept below pattern :
1.
cloudaudit.googleapis.com%2Factivity
;2.
cloudaudit.googleapis.com/activity
;3.
cloudaudit.googleapis.com%2Factivity\ncloudaudit.googleapis.com%2Factivity-function
; // Valid multiple entries4.
cloudaudit.googleapis.com