Fix multiple issues #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse the DOM result instead of looking up the DOM tree all the time.
Through the dockerignore file, we can avoid accidental operations and reduce the size of container images.
When using OpenAI Whisper model, an error will happen because words field is not an Array, which does't have foreach method.
The ScriptProcessorNode is deprecated and should be replaced with AudioWorkletNode. An AudioWorkletNode can be created with a specific AudioWorkletProcessor. The AudioWorkletProcessor parses audio data from the source node and uses a message port to send data back to the corresponding AudioWorkletNode. Each piece of audio data is a Float32Array containing 128 elements.
jinmiaoluo
force-pushed
the
refactor-audio-api-code
branch
from
df9f538 to
6231db2
Compare
When user has connected to the WebSocket server using the address from the input element, the connectButton should be disabled. When user updates the WebSocket address, the connectButton should be re-enabled. If the user is recording, it should be stopped. If a connection has been established, it should be closed. When user types 'Enter' in the input element, it should trigger the 'connect WebSocket' operation for better UI interaction.
We shall push user config to server before handling any audio data.
jinmiaoluo
force-pushed
the
refactor-audio-api-code
branch
from
3e5b3a2 to
723e46f
Compare
Use `Math.ceil()` instead of `Math.round()` to ensure there is enough space for all samples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on PR #21 , so it contains many commits.
Fix: #22 #23 #24 #25